From de6a1bef67018bb97b0da0fe4a8f132647a4ce62 Mon Sep 17 00:00:00 2001
From: Sinan <sbarut@techfak.uni-bielefeld.de>
Date: Fri, 28 Sep 2018 12:26:13 +0200
Subject: [PATCH 1/4] Remove the ascii-string converter

As said in the redmine, if someone really wishes an ascii-string
converter, he or she can add it in the repository.

The StringConverter itself has still the optional bool argument to
choose the encoding, since it does not change anything.
---
 rsb-cil/Rsb/Converter/DefaultConverterRepository.cs | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/rsb-cil/Rsb/Converter/DefaultConverterRepository.cs b/rsb-cil/Rsb/Converter/DefaultConverterRepository.cs
index 9cf1b8e..3faec9a 100644
--- a/rsb-cil/Rsb/Converter/DefaultConverterRepository.cs
+++ b/rsb-cil/Rsb/Converter/DefaultConverterRepository.cs
@@ -22,7 +22,7 @@ namespace Rsb.Converter
                 new UInt32Converter(),
                 new UInt64Converter(),
                 new BoolConverter(),
-                new StringConverter(false),
+                //new StringConverter(false), removing ascii-string converter
                 new StringConverter(),
                 new ByteConverter(),
                 //new ScopeConverter()
@@ -45,10 +45,7 @@ namespace Rsb.Converter
                         new IsExactMatch<string>(signature.Schema),
                         converter
                         ));
-                
-                // this will add a second string converter in the informer list.
-                // I assume the first one wins and i don't think, that this is intended. Checks and Exceptions should be added at sometime
-                
+                                
                 serializationConverterList.Add(
                     new Tuple<PredicateConverterSelection<Type>.Predicate, IConverter>(
                         new IsExactMatch<Type>(signature.DataType),
-- 
2.14.2.windows.1