Enhancement #1315

rsc::threading::SynchronizedQueue misses pop method with timeout parameter

Added by L. Schillingmann about 9 years ago. Updated almost 9 years ago.

Status:ResolvedStart date:12/21/2012
Priority:NormalDue date:
Assignee:J. Wienke% Done:

100%

Category:Threading
Target version:Robotics Service Bus - rsb-0.9

Associated revisions

Revision 04e5aec1
Added by J. Wienke almost 9 years ago

Add a timeout parameter to the pop method of SynchronizedQueue.

fixes #1315

Merge branch 'bug-1315'

Revision f629bcac
Added by J. Wienke almost 9 years ago

Backport: Add a timeout parameter to the pop method of SynchronizedQueue.

refs #1315

Merge branch 'bug-1315'

Revision 4c8e9ded
Added by J. Wienke almost 9 years ago

Fix pop with timeout on boost versions < 1.50.

refs #1315

Revision 37cc51dd
Added by J. Wienke almost 9 years ago

Backport: Fix pop with timeout on boost versions < 1.50.

refs #1315

History

#1 Updated by J. Wienke almost 9 years ago

  • Status changed from New to In Progress
  • Target version changed from rsb-0.7 to rsb-0.9

I will add this to 0.9 first.

#2 Updated by J. Wienke almost 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset rsc|commit:04e5aec11621791829007b4c78884b796f197b25.

#3 Updated by J. Wienke almost 9 years ago

Jan, do you think this can be merged back to 0.7 safely. As it is a template implementation ABI compatibility shouldn't be an issue and API is still compatible with the changes. Do I miss anything?

#4 Updated by J. Moringen almost 9 years ago

I don't know whether the change could break existing code.

Since the bug has been filed against 0.9, I would not backport the change unless somebody absolutely needs this.

#5 Updated by J. Wienke almost 9 years ago

I have backported this to 0.7 to make Lars happy ;)

#6 Updated by L. Schillingmann almost 9 years ago

  • Status changed from Resolved to Feedback

The pop function does not work with sub second accuracy. E.g. pop(500) does not wait any time.

#7 Updated by J. Wienke almost 9 years ago

  • Status changed from Feedback to Resolved

Added a unit test for this and fixed the behavior for old boost versions.

Also available in: Atom PDF