Feature #1490
Python lacks deserialization support for EventsByScopeMap
Status: | Resolved | Start date: | 05/07/2013 | |
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | J. Wienke | % Done: | 100% | |
Category: | Python | |||
Target version: | rsb-0.9 |
Description
There is no converter for this type.
Associated revisions
fixes #1490: Implement a converter for EventsByScopeMap.
Merge branch 'feature-1490'
History
#1 Updated by J. Wienke almost 11 years ago
- % Done changed from 0 to 60
Jan, I have committed something to a respective feature branch. Do you see any problems with this approach?
#2 Updated by J. Moringen almost 11 years ago
- I think, we decided to use
"""..."""
for docstrings - The
print
statement should be replaced with proper logging or removed - What does the empty
EventsByScopeMap
class (line 464) do? - Why can't serialization be supported?
#3 Updated by J. Moringen almost 11 years ago
Johannes Wienke wrote:
Jan, I have committed something to a respective feature branch. Do you see any problems with this approach?
Sorry, I read this as "Do you see any problems with this code?"
However, third and fourth bullet points remain.
#4 Updated by J. Wienke almost 11 years ago
Apart from the other things: I don't know how to safely implement serialization because dict
is a potentially bad type to use for type matching. This might lead to so many errors. This is also the reason why I used the internal garbage class so that this converter is not picked up by accident.
#5 Updated by J. Wienke almost 11 years ago
- % Done changed from 60 to 90
I have committed serialization support and removed the converter from the default registration. Anything else remaining here?
#7 Updated by J. Wienke almost 11 years ago
Why only 60%? ;) I will merge it back, if that's ok?
#8 Updated by J. Moringen almost 11 years ago
Johannes Wienke wrote:
Why only 60%? ;)
I did not change change the progress intentionally. Must have been a missclick or page-reload problem.
I will merge it back, if that's ok?
Sure.
#9 Updated by J. Wienke almost 11 years ago
- Status changed from In Progress to Resolved
- % Done changed from 60 to 100
Applied in changeset rsb-python|commit:160600fd72b8dbd2506cbf4490b708706d739b0c.