Bug #1502

One of the recent changes probably broke the Windows build

Added by J. Moringen over 9 years ago. Updated over 9 years ago.

Status:ResolvedStart date:05/19/2013
Priority:NormalDue date:
Assignee:J. Wienke% Done:

100%

Category:cmake
Target version:Robotics Service Bus - rsb-0.9

Description

It seems as if the RSC_EXPORTS preprocessor definition has been changed to rsc0.9_EXPORTS by recent CMake changes.

This can be seen, for example, in the configured file:
https://ci.cor-lab.org/view/rsc/job/rsc-trunk-windows/VS_VERSION=100,label=Windows_7_64bit/ws/build/src/rsc/rscexports.h
Here is the relevant snippet:

#if defined (_WIN32) 
    #if defined(rsc0.9_EXPORTS)
        #define RSC_EXPORT __declspec(dllexport)
        #define RSC_EXPIMP
    #else
        #define RSC_EXPORT __declspec(dllimport)
        #define RSC_EXPIMP extern
    #endif
#else
    #define RSC_EXPORT
#endif

@Arne: I am assigning this to you because you seem to have made changes in the relevant areas recently.

Associated revisions

Revision 3694d7b9
Added by J. Wienke over 9 years ago

fixes #1502: Fix windows builds since naming changes for the library target.

Replace the . character in the preprocessor symbols with _ as used by cmake.

Merge branch 'bug-1502'

History

#1 Updated by J. Moringen over 9 years ago

  • Subject changed from One of the recent changes probably broke the Windows to One of the recent changes probably broke the Windows build

#2 Updated by J. Wienke over 9 years ago

  • Status changed from New to In Progress
  • Assignee changed from Anonymous to J. Wienke

#3 Updated by J. Wienke over 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset rsc|commit:3694d7b99cd34bb46ccb9541e9af0a9216ef5800.

Also available in: Atom PDF