Feature #1761

Make protos available in Maven

Added by L. Ziegler almost 7 years ago. Updated almost 7 years ago.

Status:ResolvedStart date:02/12/2014
Priority:NormalDue date:
Assignee:J. Wienke% Done:

100%

Category:java
Target version:Robotics Service Bus - rsb-0.11

Description

I suggest to either package protos into the existing rst jar or deploy a separate jar containing only the proto files. This is important for users of rst-java if the want to develop new types which depend on rst protos. Right now they have to rely on a local installation of rst-proto which is against the maven spirit. A protos-jar would enable maven developers to download and unpack them dynamically at compile time.

myrstproject.tar (10 KB) L. Ziegler, 02/12/2014 10:45 AM

rst-proto.tar (210 KB) L. Ziegler, 02/12/2014 10:45 AM

Associated revisions

Revision 7988b329
Added by J. Wienke almost 7 years ago

fixes #1761: include protos in jars

Include the proto files in the generated jar files.

Revision 6c7b62a0
Added by J. Wienke almost 7 years ago

fixes #1761: include protos in jars

Include the proto files in the generated jar files.

History

#1 Updated by J. Moringen almost 7 years ago

  • Status changed from New to Feedback
  • Target version set to rsb-0.11

Please describe what the use of the proposed extension would look like in a downstream maven project (maven XML snippet would be preferable).

#2 Updated by L. Ziegler almost 7 years ago

I attached an example project that actually works if the (also attached) rst-proto project is installed to the local repository. Note that the standard maven repositories do not contain a working protoc plugin right now. That's why I have to go the detour using a script to call protoc.

#3 Updated by J. Wienke almost 7 years ago

  • Status changed from Feedback to In Progress
  • Assignee set to J. Wienke

Packaging the proto files inside the RST jars looks like a good idea. It won't hurt anyone and might help others. I will try to implement this.

#4 Updated by J. Wienke almost 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset rst-proto|commit:7988b329f53a3f993ebc0765221612f164a5138d.

#5 Updated by J. Wienke almost 7 years ago

I have pushed a patch to master. Please verify that the protos are now available in the intended way.

Also available in: Atom PDF