https://code.cor-lab.de/https://code.cor-lab.de/favicon.ico?14019720732015-06-01T15:14:30ZOpen Source Collaboration PlatformRobotics Systems Types - Enhancement #2309: New RCI Converter JointVelocitieshttps://code.cor-lab.de/issues/2309?journal_id=72122015-06-01T15:14:30ZJ. Wienkejwienke@techfak.uni-bielefeld.de
<ul></ul>A few comments wrt the patch:
<ul>
<li>Please fix the copyright statement in the headers</li>
<li>Remove the various whitespaces before uses of <code>::rci::JointVelocities</code></li>
<li>The header file lacks a new line at the end of file<br />Otherwise this looks fine.</li>
</ul> Robotics Systems Types - Enhancement #2309: New RCI Converter JointVelocitieshttps://code.cor-lab.de/issues/2309?journal_id=72132015-06-02T07:23:26ZN. Dehiondehio@techfak.uni-bielefeld.de
<ul><li><strong>File</strong> <a href="/attachments/download/487/0001-new-rci-converter-for-joint-velocities-with-updated-.patch">0001-new-rci-converter-for-joint-velocities-with-updated-.patch</a><a href="/attachments/487/0001-new-rci-converter-for-joint-velocities-with-updated-.patch"><img alt="Magnifier" src="/images/magnifier.png?1396112202" /></a> added</li></ul><p>new patch attached:<br />- updated copyright<br />- new line at the end of header file<br />=> removing whitespaces before uses of ::rci::JointVelocities leads to compiling errors. This change is not included.</p> Robotics Systems Types - Enhancement #2309: New RCI Converter JointVelocitieshttps://code.cor-lab.de/issues/2309?journal_id=72142015-06-02T08:38:37ZJ. Wienkejwienke@techfak.uni-bielefeld.de
<ul></ul><p>N. Dehio wrote:</p>
<blockquote>
<p>=> removing whitespaces before uses of ::rci::JointVelocities leads to compiling errors. This change is not included.</p>
</blockquote>
<p>Hm, the only place where I could imagine this could be inside the RSB_TYPE_TAG macro... All other places are plain C++ without preprocessor being involved. But I can have a look at that as well.</p> Robotics Systems Types - Enhancement #2309: New RCI Converter JointVelocitieshttps://code.cor-lab.de/issues/2309?journal_id=72152015-06-02T08:49:47ZN. Dehiondehio@techfak.uni-bielefeld.de
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a href="https://code.cor-lab.de/projects/rst/repository/rst-converters/revisions/6f29598d0dcf4a6c21648719641d7602d6da0c47" class="changeset" title="new rci converter for joint velocities fixes #2309 Signed-off-by: Johannes Wienke <jwienke@tech...">rst-converters|6f29598d0dcf4a6c21648719641d7602d6da0c47</a>.</p>