https://code.cor-lab.de/https://code.cor-lab.de/favicon.ico?14019720732015-12-11T11:12:03ZOpen Source Collaboration PlatformRobotics Systems Types - Enhancement #2478: Add Highlight Target typehttps://code.cor-lab.de/issues/2478?journal_id=77602015-12-11T11:12:03ZP. Holthauspholthau@cit-ec.uni-bielefeld.de
<ul><li><strong>File</strong> <a href="/attachments/download/549/0002-rename-type.patch">0002-rename-type.patch</a><a href="/attachments/549/0002-rename-type.patch"><img alt="Magnifier" src="/images/magnifier.png?1396112202" /></a> added</li></ul><p>oops, wrong file ending. also aligned comments</p> Robotics Systems Types - Enhancement #2478: Add Highlight Target typehttps://code.cor-lab.de/issues/2478?journal_id=78112016-01-06T09:21:19ZJ. Wienkejwienke@techfak.uni-bielefeld.de
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul><p>Can you please boil down the changes into a single patch that can be applied?</p> Robotics Systems Types - Enhancement #2478: Add Highlight Target typehttps://code.cor-lab.de/issues/2478?journal_id=78132016-01-06T09:31:27ZJ. Wienkejwienke@techfak.uni-bielefeld.de
<ul><li><strong>Assignee</strong> set to <i>J. Wienke</i></li></ul> Robotics Systems Types - Enhancement #2478: Add Highlight Target typehttps://code.cor-lab.de/issues/2478?journal_id=78142016-01-06T10:04:57ZP. Holthauspholthau@cit-ec.uni-bielefeld.de
<ul><li><strong>File</strong> <a href="/attachments/download/557/0001-add-highlight-target-type.patch">0001-add-highlight-target-type.patch</a><a href="/attachments/557/0001-add-highlight-target-type.patch"><img alt="Magnifier" src="/images/magnifier.png?1396112202" /></a> added</li></ul><p>here you go.</p> Robotics Systems Types - Enhancement #2478: Add Highlight Target typehttps://code.cor-lab.de/issues/2478?journal_id=78152016-01-06T11:18:52ZJ. Wienkejwienke@techfak.uni-bielefeld.de
<ul><li><strong>File</strong> <i>0001-Add-highlight-target-type.patch</i> added</li></ul><p>I have slightly revised the patch. for formal issues and changed a few names of the enumeration to be better recognizable. Is it ok to rename "GAZE" to "AGENT", since it sound strange to me that an "intelligent apartment" (as in the type description) can actually gaze.</p> Robotics Systems Types - Enhancement #2478: Add Highlight Target typehttps://code.cor-lab.de/issues/2478?journal_id=78162016-01-06T11:30:06ZP. Holthauspholthau@cit-ec.uni-bielefeld.de
<ul></ul><p>I cannot find any differences between the patch I provided and the file you uploaded.</p>
<p>J. Wienke wrote:</p>
<blockquote>
<p>Is it ok to rename "GAZE" to "AGENT", since it sound strange to me that an "intelligent apartment" (as in the type description) can actually gaze.</p>
</blockquote>
<p>The type itself should imho not be apartment-specific, but as the description says for all kinds of "intelligent systems". We have explicitly designed it to use it as a common type shared with the Meka bot as well. Therefore, I would refrain from renaming the field.</p> Robotics Systems Types - Enhancement #2478: Add Highlight Target typehttps://code.cor-lab.de/issues/2478?journal_id=78172016-01-06T11:34:00ZJ. Wienkejwienke@techfak.uni-bielefeld.de
<ul><li><strong>File</strong> deleted (<del><i>0001-Add-highlight-target-type.patch</i></del>)</li></ul> Robotics Systems Types - Enhancement #2478: Add Highlight Target typehttps://code.cor-lab.de/issues/2478?journal_id=78182016-01-06T11:35:35ZJ. Wienkejwienke@techfak.uni-bielefeld.de
<ul><li><strong>File</strong> <a href="/attachments/download/559/0001-Add-highlight-target-type.patch">0001-Add-highlight-target-type.patch</a><a href="/attachments/559/0001-Add-highlight-target-type.patch"><img alt="Magnifier" src="/images/magnifier.png?1396112202" /></a> added</li></ul><p>Oops, attached is the patch containing the changes.</p>
<blockquote><blockquote>
<p>Is it ok to rename "GAZE" to "AGENT", since it sound strange to me that an "intelligent apartment" (as in the type description) can actually gaze.</p>
</blockquote>
<p>The type itself should imho not be apartment-specific, but as the description says for all kinds of "intelligent systems". We have explicitly designed it to use it as a common type shared with the Meka bot as well. Therefore, I would refrain from renaming the field.</p>
</blockquote>
<p>I don't understand this argument. Isn't the mekabot some kind of agent?</p> Robotics Systems Types - Enhancement #2478: Add Highlight Target typehttps://code.cor-lab.de/issues/2478?journal_id=78192016-01-06T11:39:46ZP. Holthauspholthau@cit-ec.uni-bielefeld.de
<ul></ul><p>Yes, but an agent can use gaze and/or gesture, LEDs, beeps for example.</p> Robotics Systems Types - Enhancement #2478: Add Highlight Target typehttps://code.cor-lab.de/issues/2478?journal_id=78202016-01-06T11:50:11ZAnonymous
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a href="https://code.cor-lab.de/projects/rst/repository/revisions/bee6f472660d3f93583b1efa3bd5293fc00e573c" class="changeset" title="Add highlight target type fixes #2478 Signed-off-by: Johannes Wienke <jwienke@techfak.uni-biele...">rst-proto|bee6f472660d3f93583b1efa3bd5293fc00e573c</a>.</p>