Bug #2558: Events with same timestamps are replayed with changed order - RSBag - Open Source Collaboration Platform

Bug #2558

Events with same timestamps are replayed with changed order

Added by J. Wienke over 7 years ago. Updated about 6 years ago.

Status:

In Progress

Start date:

06/08/2016

Priority:

Normal

Due date:

Assignee:

J. Moringen

% Done:

20%

Category:

Replay

Target version:

Robotics Service Bus - rsb-0.18

Description

In case multiple events have the exact same timestamp (e.g. due to the limited time resolution on windows), they should be sorted in addition by their receive timestamp to ensure that they are replayed in the exact sequence as generated. This is especially important across multiple channels, as channel definitions in tide differ from RSB semantics and therefore sequential guarantees available in RSB might be loosened in bag replay.

Associated revisions

Revision f4b2bc39
Added by J. Moringen over 7 years ago

Fixed handling of repeated timestamps in src/backend/tidelog/index.lisp

refs #2558

Repeated timestamps for entries within a channel should not lead to a
warning or sorting of index entries. In fact, since index entries are
not `stable-sort'ed, sorting can be harmful in such cases.

src/backend/tidelog/index.lisp (header): updated copyright
(put-entry output-index integer integer integer): consider entries to
be in order as long the timestamp of the entry under consideration is
>= ; changed from >
test/backend/tidelog/file.lisp: new file; contains high-level tests
for the tidelog backend; currently only test for entry order
preservation in case of repeated timestamps
rsbag-tidelog.asd (header): updated copyright
(system rsbag-tidelog-test): added file test/backend/tidelog/file.lisp