Bug #2653

${next-value|${true}} evaluates true when previous value is defined as false

Added by R. Haschke over 7 years ago. Updated over 7 years ago.

Status:ClosedStart date:09/08/2016
Priority:NormalDue date:
Assignee:J. Moringen% Done:

0%

Category:Processing Model
Target version:0.7

Description

I tried to add the possibility to override the repository default settings in a distribution.
As we discussed elsewhere (I cannot find the issue anymore), using ${next-value|false} didn't work, because false would be interpreted as text and thus would evaluate to true.
Hence, I used the following definitions in commit:39a9a3684cee349ad816d7ed6f60fc0588f9e312:

"false":                            false,
"true": true,
"git.wipe-out-workspace?": "${next-value|${false}}",
"git.clean-before-checkout?": "${next-value|${true}}",

This works in principle. However, if "next-value" is defined as false, it is nevertheless considered as undefined (NIL?) and the fallback is used.
I guess, you need to distinguish undefined (NIL) and false state, when evaluating next-value expressions.

Associated revisions

Revision b1646f69
Added by J. Moringen over 7 years ago

Collapsing of Boolean and numeric values in src/project/protocol.lisp

refs #2653

  • src/project/protocol.lisp (expand): collapse Boolean and numeric
    values properly

History

#1 Updated by R. Haschke over 7 years ago

I have a test foo.distribution committed to branch rhaschke-tests.

#2 Updated by J. Moringen over 7 years ago

  • Category set to Processing Model
  • Status changed from New to In Progress

#3 Updated by J. Moringen over 7 years ago

  • Status changed from In Progress to Closed

No longer reproducible.

#4 Updated by J. Moringen over 7 years ago

  • Target version set to 0.8

#5 Updated by J. Moringen over 7 years ago

  • Target version changed from 0.8 to 0.7

Also available in: Atom PDF