Feature #2737

Add "Corenlp Dependency Tree" to SpeechHypothesis

Added by D. Hamann about 2 years ago. Updated about 2 years ago.

Status:FeedbackStart date:09/14/2017
Priority:NormalDue date:
Assignee:D. Hamann% Done:

0%

Category:Type Proposal
Target version:Robotics Service Bus - rsb-0.18

Description

branched from 0.15 and like to have it added to 0.15

0001-added-corenlp-dep-tree-to-SpeechHypothesis-and-pos-t.patch Magnifier (2.66 KB) D. Hamann, 09/14/2017 05:11 PM

0001-added-corenlp-parse-tree-to-speechhypothesis.patch Magnifier (902 Bytes) D. Hamann, 09/25/2017 02:45 PM

0002-enhanced-comment-for-corenlp-parse-tree.patch Magnifier (961 Bytes) D. Hamann, 09/25/2017 02:45 PM


Related issues

Related to Robotics Systems Types - Feature #2738: Add "Part of Speech Tag" to Word Resolved 09/24/2017

History

#1 Updated by J. Moringen about 2 years ago

  • Status changed from New to Feedback
  • Assignee set to D. Hamann

Sorry, but this cannot be merged without modification because of the following problems:

  • Please split off the part-of-speech tag change and make a separate issue.
  • Part-of-speech tag
    • Please rename the field to part_of_speech_tag
    • Please rename and/or document the enum members. Most of the abbreviations are completely unclear to non-experts. Alternatively or in addition to that, if this is a standard tagging scheme, add a reference to a description of the scheme.
  • Dependency Tree
    • The comment does not explain what corenlp or a corenlp dependency tree is or where the reader can find more information about those things.
    • Why is the dependency tree a string and not tree data structure? (Same goes for grammar tree, btw. But that may be too late)
    • If it has to be string, the comment should explain its structure and interpretation.

#2 Updated by J. Moringen about 2 years ago

  • Subject changed from Add SpeechHypothesis to the sandbox to Add "Corenlp Dependency Tree" to SpeechHypothesis

#3 Updated by D. Hamann about 2 years ago

split off additions and made commentary better.
also renamed the "dependency"-tree to more generic "parse"-tree.
it is a string because we want to store the parse-results in xml format and use xpath on it.

#4 Updated by J. Moringen about 2 years ago

  • Please rename corenlp_parse_tree to just parse_tree and document it in a way that makes it usable without knowing what CoreNLP is.
  • Please add a link that explains the XML format. Not sure whether the "lex-parser" link should remain for context.
  • Please add an example to the documentation string.
  • There seems to be a protocol buffer-based format for CoreNLP: https://github.com/stanfordnlp/CoreNLP/blob/master/src/edu/stanford/nlp/pipeline/CoreNLP.proto. Could (parts of) this be used instead of an XML string?

#5 Updated by J. Moringen about 2 years ago

  • Related to Feature #2738: Add "Part of Speech Tag" to Word added

#6 Updated by J. Moringen about 2 years ago

  • Target version set to rsb-0.17

#7 Updated by J. Moringen about 2 years ago

  • Target version changed from rsb-0.17 to rsb-0.18

Also available in: Atom PDF