https://code.cor-lab.de/https://code.cor-lab.de/favicon.ico?14019720732017-09-21T11:41:20ZOpen Source Collaboration PlatformRobotics Systems Types - Feature #2737: Add "Corenlp Dependency Tree" to SpeechHypothesishttps://code.cor-lab.de/issues/2737?journal_id=92562017-09-21T11:41:20ZJ. Moringenjmoringe@cor-lab.uni-bielefeld.de
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>Assignee</strong> set to <i>D. Hamann</i></li></ul><p>Sorry, but this cannot be merged without modification because of the following problems:</p>
<ul>
<li>Please split off the part-of-speech tag change and make a separate issue.</li>
<li>Part-of-speech tag
<ul>
<li>Please rename the field to <code>part_of_speech_tag</code></li>
<li>Please rename and/or document the enum members. Most of the abbreviations are completely unclear to non-experts. Alternatively or in addition to that, if this is a standard tagging scheme, add a reference to a description of the scheme.</li>
</ul>
</li>
<li>Dependency Tree
<ul>
<li>The comment does not explain what corenlp or a corenlp dependency tree is or where the reader can find more information about those things.</li>
<li>Why is the dependency tree a string and not tree data structure? (Same goes for grammar tree, btw. But that may be too late)</li>
<li>If it has to be string, the comment should explain its structure and interpretation.</li>
</ul></li>
</ul> Robotics Systems Types - Feature #2737: Add "Corenlp Dependency Tree" to SpeechHypothesishttps://code.cor-lab.de/issues/2737?journal_id=92572017-09-21T11:41:48ZJ. Moringenjmoringe@cor-lab.uni-bielefeld.de
<ul><li><strong>Subject</strong> changed from <i>Add SpeechHypothesis to the sandbox</i> to <i>Add "Corenlp Dependency Tree" to SpeechHypothesis</i></li></ul> Robotics Systems Types - Feature #2737: Add "Corenlp Dependency Tree" to SpeechHypothesishttps://code.cor-lab.de/issues/2737?journal_id=92582017-09-25T12:45:35ZD. Hamanndhamann@techfak.uni-bielefeld.de
<ul><li><strong>File</strong> <a href="/attachments/download/606/0001-added-corenlp-parse-tree-to-speechhypothesis.patch">0001-added-corenlp-parse-tree-to-speechhypothesis.patch</a><a href="/attachments/606/0001-added-corenlp-parse-tree-to-speechhypothesis.patch"><img alt="Magnifier" src="/images/magnifier.png?1396112202" /></a> added</li><li><strong>File</strong> <a href="/attachments/download/607/0002-enhanced-comment-for-corenlp-parse-tree.patch">0002-enhanced-comment-for-corenlp-parse-tree.patch</a><a href="/attachments/607/0002-enhanced-comment-for-corenlp-parse-tree.patch"><img alt="Magnifier" src="/images/magnifier.png?1396112202" /></a> added</li></ul><p>split off additions and made commentary better.<br />also renamed the "dependency"-tree to more generic "parse"-tree.<br />it is a string because we want to store the parse-results in xml format and use xpath on it.</p> Robotics Systems Types - Feature #2737: Add "Corenlp Dependency Tree" to SpeechHypothesishttps://code.cor-lab.de/issues/2737?journal_id=92602017-09-28T09:13:29ZJ. Moringenjmoringe@cor-lab.uni-bielefeld.de
<ul></ul><ul>
<li>Please rename <code>corenlp_parse_tree</code> to just <code>parse_tree</code> and document it in a way that makes it usable without knowing what CoreNLP is.</li>
<li>Please add a link that explains the XML format. Not sure whether the "lex-parser" link should remain for context.</li>
<li>Please add an example to the documentation string.</li>
<li>There seems to be a protocol buffer-based format for CoreNLP: <a class="external" href="https://github.com/stanfordnlp/CoreNLP/blob/master/src/edu/stanford/nlp/pipeline/CoreNLP.proto">https://github.com/stanfordnlp/CoreNLP/blob/master/src/edu/stanford/nlp/pipeline/CoreNLP.proto</a>. Could (parts of) this be used instead of an XML string?</li>
</ul> Robotics Systems Types - Feature #2737: Add "Corenlp Dependency Tree" to SpeechHypothesishttps://code.cor-lab.de/issues/2737?journal_id=92922017-09-29T12:56:19ZJ. Moringenjmoringe@cor-lab.uni-bielefeld.de
<ul><li><strong>Related to</strong> <i><a href="/issues/2738" class="issue tracker-2 status-3 priority-4 priority-default closed">Feature #2738</a>: Add "Part of Speech Tag" to Word</i> added</li></ul> Robotics Systems Types - Feature #2737: Add "Corenlp Dependency Tree" to SpeechHypothesishttps://code.cor-lab.de/issues/2737?journal_id=92932017-09-29T12:56:29ZJ. Moringenjmoringe@cor-lab.uni-bielefeld.de
<ul><li><strong>Target version</strong> set to <i>rsb-0.17</i></li></ul> Robotics Systems Types - Feature #2737: Add "Corenlp Dependency Tree" to SpeechHypothesishttps://code.cor-lab.de/issues/2737?journal_id=94252017-10-16T19:23:28ZJ. Moringenjmoringe@cor-lab.uni-bielefeld.de
<ul><li><strong>Target version</strong> changed from <i>rsb-0.17</i> to <i>rsb-0.18</i></li></ul>