Enhancement #2769

Removing the ascii serializer

Added by S. Barut 12 months ago. Updated 12 months ago.

Status:ResolvedStart date:09/28/2018
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:C#
Target version:-

Description

Since the string type has two converters (one for utf-8-string, one for ascii-string), the ConverterSelector needs a strategy to decide, which converter should be used to serialize a string.
Since the strategy does not exist, it is a first-registered-converts strategy.
At least I want to favor utf-8-string and to make it clearly, the ascii-string converter is removed from the serializationConverterList in the default repository. (instead of just reorder the default converter list)

0002-Remove-the-ascii-string-default-serializer_685072f.patch Magnifier (1.55 KB) S. Barut, 09/28/2018 12:58 PM

0001-Remove-the-ascii-string-converter_531bea6.patch Magnifier (1.89 KB) S. Barut, 10/01/2018 02:09 PM

Associated revisions

Revision d138e5f6
Added by S. Barut 12 months ago

Remove the ascii-string converter from defaults

As discussed in #2769, if someone really wishes an ascii-string
converter, he or she can add it in the repository.

The StringConverter itself has still the optional bool argument to
choose the encoding, since it does not change anything.

fixes #2769

Signed-off-by: Johannes Wienke <>

History

#1 Updated by J. Wienke 12 months ago

Maybe a better solution would be not to include the ascii string converter in the list of default converters at all? If someone needs that converter, he or she could use a custom strategy.

#2 Updated by S. Barut 12 months ago

Sure. I wouldn't mind, if it gets removed.

#3 Updated by S. Barut 12 months ago

Removed from the default list (commented out).
Also rebased to 531bea6

#4 Updated by S. Barut 12 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF