Enhancement #457: Remove Notification.version? - Robotics Service Bus - Open Source Collaboration Platform

Enhancement #457

Status:

Resolved

Start date:

07/29/2011

Priority:

Low

Due date:

Assignee:

% Done:

100%

Category:

Protocol

Target version:

Description

The field Notification.version is currently not processed in any implementation (I think). I propose removing it:

Saves five bytes
We have/want build-time checks now
We cannot handle incompatible changes at runtime anyway
Also, we can detect incompatible versions differently:
We can use a required field like Notification.sequence_number and set the field number to 100 + ${WIRE_PROTOCOL_VERSION}$
This would make protocol buffer unpacking fail for incompatible wire protocol versions

Removed Notification.version field in protocol/RSBProtocol/Protocol.proto
refs #457

protocol/RSBProtocol/Protocol.proto: removed unused
Notification.version field; bumped filed number of
Notification.sequence_number to 100 to make this usable for
detection of wire-format incompatibilities

Added field number from wire format in protocol/
fixes #457

protocol/CMakeLists.txt: generate field number of
Notification.sequence_number based wire format version number;
configure protocol/RSBProtocol/Protocol.proto.in with this field
number
protocol/RSBProtocol/Protocol.proto.in: renamed
protocol/RSBProtocol/Protocol.proto ->
protocol/RSBProtocol/Protocol.proto.in