Bug #518

RSC Logger Level naming too generic

Added by Anonymous over 12 years ago. Updated over 12 years ago.

Status:ResolvedStart date:08/22/2011
Priority:NormalDue date:
Assignee:J. Wienke% Done:

100%

Category:LoggingEstimated time:1.00 hour
Target version:-

Description

I stumbled upon a piece of software, that sets the compiler flag -DDEBUG, if compiled as Debug, not Release. When using this software and RSC this breaks with the current naming of RSC logger levels (being ALL, TRACE, DEBUG and so on). Setting this compiler flag is not too rarely I think, so I suggest to give the logger levels a less generic name with a lower probability of producing a conflict, e.g. DEBUG => RSC_DEBUG or similar.
Any opinions on that?

Associated revisions

Revision dcbe3dbf
Added by Arne Nordmann over 12 years ago

Changed member names of logger level enumeration ('DEBUG'->'LEVEL_DEBUG', 'TRACE'->'LEVEL_TRACE', ...) due to #518.
Might break some depending implementations.
fixes #518

History

#1 Updated by J. Wienke over 12 years ago

Narf, they are already in a namespace, class and enum... The preprocessor is evil...
https://code.cor-lab.org/projects/rsc/repository/entry/trunk/rsc/src/rsc/logging/Logger.h

I would propose LEVEL_XXX

#2 Updated by Anonymous over 12 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset r337.

Also available in: Atom PDF