Bug #1972

Composite state transitions are displayed erronous

Added by N. Köster over 9 years ago. Updated almost 8 years ago.

Status:NewStart date:09/01/2014
Priority:HighDue date:
Assignee:P. Holthaus% Done:

0%

Category:-
Target version:Language Engineering - Language Refactoring

Description

The state which is transitioned to after a composite state is always included within the composite state itself (see image)

@startuml
title example
[*] --> s1
state s1
s1 --> composite_s1
state composite_s1 {
state sub_s1
sub_s1 --> external_s2
}
state external_s2 
@enduml

Leads to:

however, a different plantuml syntax (moving the following state before the composite state) created the correct image:

@startuml
title example
[*] --> s1
state s1
s1 --> composite_s1
state external_s2 
state composite_s1 {
state sub_s1
sub_s1 --> external_s2
}
@enduml

Leads to:

So, should we adjust the DSL to work with this?

comp1.png (8.51 KB) N. Köster, 09/01/2014 04:19 PM

comp0.png (8.73 KB) N. Köster, 09/01/2014 04:21 PM

rendering-error-2.png (8.86 KB) S. Wrede, 09/01/2014 06:45 PM

rendering-error-2.png (8.86 KB) S. Wrede, 09/01/2014 06:45 PM

Associated revisions

Revision f5d294da
Added by Arne Nordmann almost 9 years ago

Migration to 3.2 and fixes

  • Composite states now can have compartments
  • Introduced external transition with explicit source and target

refs #1972
refs #2054

History

#1 Updated by S. Wrede over 9 years ago

This seems to be a bug in the plantUML renderer. Rendering all top-level states at the top of the file and all transitions at the end of the file should help. This can be enforced in the generator implementation.

#2 Updated by S. Wrede over 9 years ago

Even worse the following

@startuml
title example
[*] --> s1
state s1
s1 --> composite_s1
state external_s2
external_s2 --> sub_s1
state composite_s1 {
state sub_s1
sub_s1 --> external_s2
}
@enduml

leads to the following diagram:

#3 Updated by N. Köster over 9 years ago

  • Priority changed from Normal to High

The lsp-csra kitchen scenario plantuml is also affected by this. Moving transitions at the bottom solves this issue. Its quite important, as all rendered images which include composite states have those errors and need to be modified by hand.

#4 Updated by S. Wrede almost 8 years ago

  • Assignee changed from S. Wrede to P. Holthaus
  • Target version set to Language Refactoring

Is this still a problem?

#5 Updated by S. Wrede almost 8 years ago

This seems to be fixed in master. See solution Test, Model Issue1972.

Also available in: Atom PDF