Bug #812

RSBVideoReceiver Compilation Broken / Broken YUV422 Conversion

Added by S. Wrede over 12 years ago. Updated over 12 years ago.

Status:ResolvedStart date:01/20/2012
Priority:NormalDue date:
Assignee:M. Havlena% Done:

100%

Category:-
Target version:-

Description

Due to the fact that the RSBVideoReceiver is currently not versioned but used in a 0.5 as well as a 0.6 deployment context, we should explicit take of that. Furthermore, the following isses were reported by Michal:

1) gcc 4.6.1 does not like assigning * types to &
rsbvideosender.cpp:98:60: error: invalid initialization of non-const reference 
of type ‘rsc::logging::LoggerFactory&’ from an rvalue of type 
‘rsc::logging::LoggerFactory*’         
rsbvideoreceiver.cpp:77:60: error: invalid initialization of non-const 
reference of type ‘rsc::logging::LoggerFactory&’ from an rvalue of type 
‘rsc::logging::LoggerFactory*’
this can be easily fixed by using LoggerFactory* and -> instead of . on the 
following line

2) for message of type COLOR_YUV422, it seems that no image data are allocated 
before calling the conversion to BGR, so there might be an extra line before 
216 of IplImageConverter.cpp:
cvCreateData(image);
otherwise it produces a SegmentationFault (at least with mine OpenCV 2.3.1)

3) messages sent by the robot (Atom head, SDK1.12-RSB0.5-alpha) have 
channels() set to 2, this is probably a bug. As a workaround, I had to change 
line 203 of IplImageConverter.cpp to:
            3);

Related issues

Copied to RSB OpenCV - Bug #2688: RSBVideoReceiver Compilation Broken / Broken YUV422 Conve... Resolved 01/20/2012

History

#1 Updated by M. Havlena over 12 years ago

  • Status changed from New to Resolved

1) was fixed by David already
2) and 3) was just commited by me

#2 Updated by S. Wrede over 12 years ago

  • Assignee changed from S. Wrede to M. Havlena
  • % Done changed from 0 to 100

Great! Thx for the fix!

#3 Updated by S. Wrede over 12 years ago

  • Target version deleted (0.6)

#4 Updated by J. Moringen over 7 years ago

  • Copied to Bug #2688: RSBVideoReceiver Compilation Broken / Broken YUV422 Conversion added

Also available in: Atom PDF