Bug #2354

Sending doubles vector using rsb-toolscl0.13 send

Added by D. Barbot over 8 years ago. Updated over 8 years ago.

Status:ResolvedStart date:07/28/2015
Priority:NormalDue date:
Assignee:J. Moringen% Done:

100%

Category:Common Lisp Tools
Target version:rsb-0.13

Description

It seems there is a problem when using rsb-toolscl0.13 send to send negative doubles between -1.0 and 1.0.
The values being sent as positive only.

In the enclosed file, I used a RSB informer program at first to send the values 0.5, -0.5, 0.1 and -0.1.
Then, I used the rsb-toolscl0.13 send for the same values using commands such as the following:
> rsb-toolscl0.13 send -l/vol/toolkit/nightly/trusty/x86_64/successful/share/rst0.13/proto/stable/rst/math/VectorDouble.proto 'pb:.rst.math.VectorDouble:{data: [0.5]}' '/test'
Results threw the logger are explicit.

I didn't try with other versions of the tool than the current /vol/toolkit/nightly/trusty/x86_64/successful/ folder one (being folder 117 at the moment). Neither did I with other senders like the cpp one.

Screenshot - Debug RSB send.png (73.8 KB) D. Barbot, 07/28/2015 11:18 AM

Associated revisions

Revision 362c0e5c
Added by J. Moringen over 8 years ago

Fixed float rule in common/protocol-buffer-payload.lisp

Float literals were parsed incorrectly w.r.t. to a leading "+" or "-"
sign character.

fixes #2354

  • common/protocol-buffer-payload.lisp (sign): new rule; sign for numbers
    literals
    (float): fixed sign handling and result construction; use new `sign'
    rule
  • test/common/protocol-buffer-payload.lisp
    (test protocol-buffer-payload-root::grammar/smoke): added a few cases
    exercising the parsing of float literals

Revision 816ca7e0
Added by J. Moringen over 8 years ago

Backport: Fixed float rule in common/protocol-buffer-payload.lisp

Float literals were parsed incorrectly w.r.t. to a leading "+" or "-"
sign character.

refs #2354

  • common/protocol-buffer-payload.lisp (sign): new rule; sign for numbers
    literals
    (float): fixed sign handling and result construction; use new `sign'
    rule
  • test/common/protocol-buffer-payload.lisp
    (test protocol-buffer-payload-root::grammar/smoke): added a few cases
    exercising the parsing of float literals

(cherry picked from commit 362c0e5cd64e7cc3dfa93fcc5d8d7feca2fd2b66)

History

#1 Updated by J. Moringen over 8 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 50

#2 Updated by J. Moringen over 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100

Also available in: Atom PDF