Bug #2386: C++ spread plugin crashes when using multiple threads + informers on Windows - Robotics Service Bus - Open Source Collaboration Platform

Bug #2386

C++ spread plugin crashes when using multiple threads + informers on Windows

Added by M. Goerlich about 8 years ago. Updated over 6 years ago.

Status:

Resolved

Start date:

09/10/2015

Priority:

Normal

Due date:

Assignee:

J. Moringen

% Done:

100%

Category:

Spread Connector

Target version:

rsb-0.17

Description

The spread library does not seem to be thread safe under windows (though stated within the documentation).

This touches RSB since it also causes crashes when one creates two rsb informers and sends data through two different threads. These infomers share the same spread connection.

See attached code, funny windows dump thingy and funky stacktrace-screenshot for more info.

It looks like a possible fix might be to protect the send and receive calls with a mutex-lock.

thread-test.cpp (3.86 KB) M. Goerlich, 09/10/2015 05:11 PM

stacktrace.png (154 KB) M. Goerlich, 09/10/2015 05:11 PM

thread-test.dmp.tar.gz (20.5 MB) M. Goerlich, 09/10/2015 05:11 PM

Associated revisions

Revision fb774a0e
Added by J. Moringen over 6 years ago

Fixed(?) Spread thread-safety issue in src/rsb/transport/spread/SpreadConnection.{h,cpp}

At least for sending messages, the Spread client library does not seem
to be thread-safe on win32 (despite what the documentation says).

This fix seems to work but has only been verified experimentally. In
particular, it is not clear, whether all other combinations of Spread
client API functions are thread-safe.

fixes #2386

src/rsb/transport/spread/SpreadConnection.{h,cpp} (header): updated
copyright
(SpreadConnection::mutex): new member; for critical section in send
on win32
(SpreadConnection::send): turned Spread client API calls into
critical section on win32

Revision e933fbb5
Added by J. Moringen over 6 years ago

Backport: Fixed(?) Spread thread-safety issue in src/rsb/transport/spread/SpreadConnection.{h,cpp}

At least for sending messages, the Spread client library does not seem
to be thread-safe on win32 (despite what the documentation says).

This fix seems to work but has only been verified experimentally. In
particular, it is not clear, whether all other combinations of Spread
client API functions are thread-safe.

refs #2386

src/rsb/transport/spread/SpreadConnection.{h,cpp} (header): updated
copyright
(SpreadConnection::mutex): new member; for critical section in send
on win32
(SpreadConnection::send): turned Spread client API calls into
critical section on win32

(cherry picked from commit fb774a0e93a4f9947285f320f294b7e92600652b)

History

#1 Updated by J. Wienke about 8 years ago

Status changed from New to In Progress
Assignee set to J. Wienke
Target version set to rsb-0.13

This exception is raise by our code as a result of a failure return code from the spread library. Unfortunately. In your screenshot I cannot see the string contained in the exception. Is there any way for you to reproduce this and to print out the what() of the thrown exception?

#2 Updated by M. Goerlich about 8 years ago

Hey Johannes,

probably it would be best if I showed you the bug on the windows machine in the CSRA environment. I will be there tomorrow starting from at the latest 10 o'clock, open end. The same goes for Wednesday and Thursday.

#3 Updated by J. Moringen almost 8 years ago

Subject changed from c++ spread plugin crashes when using multiple threads + informers to C++ spread plugin crashes when using multiple threads + informers on Windows