Bug #2601
Options of logger styles do not work as expected
| Status: | Resolved | Start date: | 07/13/2016 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | J. Moringen | % Done: | 100% | |
| Category: | Common Lisp Tools | |||
| Target version: | - |
Description
Some options of logger styles do not work as expected.
Associated revisions
Fixed comparison of symbol values in src/formatting/protocol.lisp
refs #2601
- src/formatting/protocol.lisp (value< symbol symbol): new method;
compare symbols by name
Fixed :columns initarg processing in src/formatting/event-style-monitor.lisp
fixes #2601
The problem was that `monitor-style-mixin' uses a function that creates
a set of columns whenever a monitor line is created. To allow supplying
column specifications via the :columns initarg, such specifications have
to be transformed into a suitable function.
- src/formatting/event-style-monitor.lisp (monitor-style-mixin::columns):
removed initarg; added style-%columns accessor
(monitor-style-mixin): removed :columns default initarg
(initialize-instance :before monitor-style-mixin): new method; make
sure that at least one of the columns and default-columns initargs is
supplied
(shared-initialize :after monitor-style-mixin t): new method; if
necessary, transform list of column specification into column creation
function - src/formatting/event-style-monitor.lisp (define-monitor-style): use
:default-columns initarg instead of :columns
(style-monitor/scope/tree): likewise - src/formatting/event-style-timeline.lisp (header): updated copyright
(define-timeline-style): use :default-columns initarg instead of
:columns
Backport: Fixed comparison of symbol values in src/formatting/protocol.lisp
refs #2601
- src/formatting/protocol.lisp (value< symbol symbol): new method;
compare symbols by name
(cherry picked from commit b92c2ce2a923e8571943290c64de8cfc48d50b9d)
Backport: Fixed :columns initarg processing in src/formatting/event-style-monitor.lisp
refs #2601
The problem was that `monitor-style-mixin' uses a function that creates
a set of columns whenever a monitor line is created. To allow supplying
column specifications via the :columns initarg, such specifications have
to be transformed into a suitable function.
- src/formatting/event-style-monitor.lisp (monitor-style-mixin::columns):
removed initarg; added style-%columns accessor
(monitor-style-mixin): removed :columns default initarg
(initialize-instance :before monitor-style-mixin): new method; make
sure that at least one of the columns and default-columns initargs is
supplied
(shared-initialize :after monitor-style-mixin t): new method; if
necessary, transform list of column specification into column creation
function - src/formatting/event-style-monitor.lisp (define-monitor-style): use
:default-columns initarg instead of :columns
(style-monitor/scope/tree): likewise - src/formatting/event-style-timeline.lisp (header): updated copyright
(define-timeline-style): use :default-columns initarg instead of
:columns
(cherry picked from commit 553713e8e5a59aa5f432b21b71c3f3fc52dd92b7)
Backport: Fixed comparison of symbol values in src/formatting/protocol.lisp
refs #2601
- src/formatting/protocol.lisp (value< symbol symbol): new method;
compare symbols by name
(cherry picked from commit b92c2ce2a923e8571943290c64de8cfc48d50b9d)
Backport: Fixed :columns initarg processing in src/formatting/event-style-monitor.lisp
refs #2601
The problem was that `monitor-style-mixin' uses a function that creates
a set of columns whenever a monitor line is created. To allow supplying
column specifications via the :columns initarg, such specifications have
to be transformed into a suitable function.
- src/formatting/event-style-monitor.lisp (monitor-style-mixin::columns):
removed initarg; added style-%columns accessor
(monitor-style-mixin): removed :columns default initarg
(initialize-instance :before monitor-style-mixin): new method; make
sure that at least one of the columns and default-columns initargs is
supplied
(shared-initialize :after monitor-style-mixin t): new method; if
necessary, transform list of column specification into column creation
function - src/formatting/event-style-monitor.lisp (define-monitor-style): use
:default-columns initarg instead of :columns
(style-monitor/scope/tree): likewise - src/formatting/event-style-timeline.lisp (header): updated copyright
(define-timeline-style): use :default-columns initarg instead of
:columns
(cherry picked from commit 553713e8e5a59aa5f432b21b71c3f3fc52dd92b7)
History
#1 Updated by J. Moringen almost 8 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset rsb-tools-cl|553713e8e5a59aa5f432b21b71c3f3fc52dd92b7.