Feature #2764
Converter Repository
Status: | Resolved | Start date: | 09/24/2018 | |
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | - | % Done: | 100% | |
Category: | C# | |||
Target version: | - |
Description
As the other languages also offer a repository for convertes to specific types, one is implemented for the C# implementation, too.
Additionally converters for the default types are implemented.
The registration of new types based on Google Protobuf has to be implemented yet.
Associated revisions
History
#1 Updated by J. Wienke over 5 years ago
There are a few issues with this so far:
- Please split the implementation of the repository from adding new converters and open a new issue for the new converters
- The converters themselves know what wire type they are responsible for (e.g. "bytes"). This information shouldn't be repeated in the converter repository itself again. Instead, there should be a register function which adds new converters and puts them into the map using their supplied information.
- The usual vocabulary is "serialization" and "deserialization" for the two directions of communication, not "informer" and "listener". E.g. C++ uses "getConvertersForSerialization" as the method name.
Could you please update the patches and issues accordingly?
#2 Updated by S. Barut over 5 years ago
- File 0003-Add-a-default-repository.patch added
So, here is the new default repository patch. But it depends on the converter patch.
#3 Updated by S. Barut over 5 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset rsb-net|685072f625463dce7bc0d87a60f113f6f8b1793a.