Feature #2764

Converter Repository

Added by S. Barut 12 months ago. Updated 12 months ago.

Status:ResolvedStart date:09/24/2018
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:C#
Target version:-

Description

As the other languages also offer a repository for convertes to specific types, one is implemented for the C# implementation, too.
Additionally converters for the default types are implemented.

The registration of new types based on Google Protobuf has to be implemented yet.

0002-Add-a-default-repository.patch Magnifier (18.6 KB) S. Barut, 09/24/2018 01:00 PM

0003-Add-a-default-repository.patch Magnifier (9.54 KB) S. Barut, 09/26/2018 04:31 PM

Associated revisions

Revision 685072f6
Added by S. Barut 12 months ago

Add a default repository

fixes #2764

Signed-off-by: Johannes Wienke <>

History

#1 Updated by J. Wienke 12 months ago

There are a few issues with this so far:
  • Please split the implementation of the repository from adding new converters and open a new issue for the new converters
  • The converters themselves know what wire type they are responsible for (e.g. "bytes"). This information shouldn't be repeated in the converter repository itself again. Instead, there should be a register function which adds new converters and puts them into the map using their supplied information.
  • The usual vocabulary is "serialization" and "deserialization" for the two directions of communication, not "informer" and "listener". E.g. C++ uses "getConvertersForSerialization" as the method name.

Could you please update the patches and issues accordingly?

#2 Updated by S. Barut 12 months ago

So, here is the new default repository patch. But it depends on the converter patch.

#3 Updated by S. Barut 12 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF