Enhancement #466

Add Future-based Interface to Request/Reply Subsystem

Added by J. Moringen almost 13 years ago. Updated almost 13 years ago.

Status:ResolvedStart date:08/03/2011
Priority:NormalDue date:
Assignee:J. Moringen% Done:

100%

Category:C++
Target version:0.4

Associated revisions

Revision 3e6d717c
Added by J. Moringen almost 13 years ago

Changed RemoteServer interface to use futures
fixes #466
  • src/rsb/Factory.{h,cpp}: removed timeout parameter from
    Factory::createRemoteServer; timeouts are now specified for
    individual function calls
  • src/rsb/patterns/RemoteServer.{h,cpp}: removed a whole bunch of
    logic from WaitingEventHandler since this stuff is now handled by
    RSC's Future class; changed RemoteServer interface to offer two
    pairs of methods: call/callAndWait and callMethod/callMethodAndWait
  • examples/server/client.cpp: adapted to changed interface of
    RemoteServer class

Revision 03f42350
Added by J. Moringen almost 13 years ago

Adapted C++ client to new future-based API in integrationtest/cpp/client.cpp
refs #466
  • integrationtest/cpp/client.cpp: replaced calls to call() with calls
    to callAndWait()

Revision 2e31b8a5
Added by J. Moringen almost 13 years ago

Fixed client/server example in examples/server/
refs #466
  • examples/server/client.cpp: call waiting variants of all methods to
    maintain previous behavior
  • examples/server/server.cpp: updated copyright

Revision 187fb449
Added by J. Moringen almost 13 years ago

Renamed call methods in src/rsb/patterns/RemoteServer.{h,cpp}
fixes #466
  • src/rsb/patterns/RemoteServer.{h,cpp}: change names of call methods
    callMethodAndWait -> call, callAndWait -> call, callMethod ->
    callAsync, call -> callAsync
  • examples/server/client.cpp: adapted to changed client interface

Revision df3cdf70
Added by J. Moringen almost 13 years ago

Adapted C++ client to changed method names in RPC API
refs #466
  • cpp/client.cpp: changed method calls callAndWait -> call

History

#1 Updated by J. Moringen almost 13 years ago

  • Status changed from New to In Progress
  • Assignee set to J. Moringen

#2 Updated by J. Moringen almost 13 years ago

  • % Done changed from 0 to 70

#3 Updated by J. Moringen almost 13 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 70 to 100

Applied in changeset r2277.

#4 Updated by J. Moringen almost 13 years ago

  • Status changed from Resolved to Feedback

Please provide feedback regarding the client interface. I'm not too happy with the call, callAndWait, callMethod, callMethodAndWait names.

Alternatives (which don't seem better to me) include
  • dataCall, eventCall, -AndWait
  • dataCall, blockingDataCall, eventCall, ...
  • call, callWithEvent, -AndWait
  • call, callWithEvent, blocking-

#5 Updated by J. Wienke almost 13 years ago

data and eventCalls sounds more clear to me. Personally, I could live with completely removing the andWait methods, but ok...

#6 Updated by J. Moringen almost 13 years ago

  • Status changed from Feedback to Resolved

Applied in changeset r2303.

Also available in: Atom PDF