Enhancement #941: Support negative arguments to --{start,end}-index in bag-{cat,play} - RSBag - Open Source Collaboration Platform

Enhancement #941

Status:

Resolved

Start date:

03/12/2012

Priority:

Low

Due date:

Assignee:

% Done:

100%

Category:

Commandline Tools

Target version:

Description

For parity with --{start,end}-time.

Also, extend description of commandline options to mention this.

Improved --{start,end}-{index,time} in common/options.lisp

fixes #941

common/options.lisp (make-replay-options): allow negative integers for
--{start,end}-index; describe interpretation of negative values for
--{start,end}-{index,time} options; whitespace improvements
(process-bounds-options): adjusted description

Allow negative {start,end}-index in src/rsb/replay/strategy-mixins.lisp

refs #941

src/rsb/replay/strategy-mixins.lisp (bounds-mixin::start-index):
changed type allow `integer' instead of only `non-negative-integer'
(bounds-mixin::end-index): likewise
(replay :before replay-bag-connection bounds-mixin): interpret
negative values of start-index and end-index as offsets from the end
of the sequence; check that start-index and end-index are within the
bounds of the sequence
(check-ordered-indices): handle cases of two positive indices and two
negative indices separately
test/rsb/strategy-mixins.lisp
(define-replay-strategy-construction-test bounds-mixin): expect
negative start and end indices to work
test/rsb/as-fast-as-possible.lisp: minor cosmetic changes
test/rsb/recorded-timing.lisp: likewise
test/rsb/fixed-rate.lisp
(define-replay-strategy-smoke-test fixed-rate): specify
required-initargs
test/rsb/package.lisp (call-as-replay-strategy-test-case): support
`replay-error'
(define-replay-strategy-smoke-test): accept keyword parameter
required-arguments; include cases with valid negative start and end
indices; add cases with invalid start and end indices using
required-arguments