Enhancement #1096
QueuePushHandler should not pollute main namespace of RSB
| Status: | Resolved | Start date: | 07/24/2012 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | J. Wienke | % Done: | 100% | |
| Category: | C++ | |||
| Target version: | rsb-0.10 |
Description
Currently the queue push handler resides in the top-level namespace of RSB, which looks kind of awkward to me as it is a utility class, which is not necessary for RSB to function properly. I would vote to move it to a util namespace or something like that. If we don't do it now, the API break will get event worse later if more of these special handlers are there.
History
#1 Updated by J. Wienke over 10 years ago
This also includes EventQueuePushHandler
#2 Updated by J. Moringen over 10 years ago
- Target version changed from rsb-0.9 to rsb-0.10
#3 Updated by J. Wienke over 9 years ago
- Status changed from New to In Progress
- Assignee set to J. Wienke
#4 Updated by J. Wienke over 9 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Implemented in rsb-cpp|53b9a870
#5 Updated by J. Moringen over 9 years ago
Since this constitutes an incompatible API change, can you add it to the section for version 0.10 in news.rst in the manual?
#6 Updated by J. Wienke over 9 years ago
Backwards compatibility is so far maintained with a deprecation warning. Do you think this is necessary then?
#7 Updated by J. Moringen over 9 years ago
Maybe a note could be added so people can start to migrate?
#8 Updated by J. Wienke over 9 years ago
A deprecation compiler warning is issues in case you are using the old includes. I think we discussed that this is enough so far.