Bug #1421
Verify that string encoding change complies to TIDELog specification
| Status: | Closed | Start date: | 02/15/2013 | ||
|---|---|---|---|---|---|
| Priority: | Normal | Due date: | |||
| Assignee: | - | % Done: | 80% | ||
| Category: | Documentation | ||||
| Target version: | Robotics Service Bus - rsb-0.10 |
Description
The publicly available version of the TIDELog specification is unclear regarding length fields for strings (in this case taken from the table specifying the CHAN block):
Name size 1 unsigned byte Length of the channel name. Name ``Name size`` characters Name of the channel, as a character string.
"``Name size`` characters" requires a string encoding to be specified. Alternative, "``Name size`` bytes" could be the intended meaning.
In both cases, clarification is needed.
Associated revisions
Fixed length computation for strings in src/backend/tidelog/generator.lisp
refs #1421
This is a very unsatisfying change because the TIDELog specifications
explicitly states that length fields for strings specify the number of
characters. But since no encoding is specified, they probably meant
the number of bytes.
- src/backend/tidelog/generator.lisp (type-spec->serializer/buffer):
use number of bytes instead of number of characters as "length" of
strings
(type-spec->serializer/stream): likewise
History
#1 Updated by J. Moringen about 11 years ago
- Target version changed from rsb-0.9 to rsb-0.10
#2 Updated by J. Moringen about 11 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 80
I discussed this with Ingo and he submitted an updated version. It has not yet been accepted, though.
#3 Updated by J. Moringen over 10 years ago
- Status changed from In Progress to Closed
I guess, that's all we can do at the moment.