Bug #1662

6c1e55c6 broke converter selection - and unit tests did not catch it

Added by J. Moringen almost 8 years ago. Updated almost 8 years ago.

Status:ResolvedStart date:11/22/2013
Priority:HighDue date:
Assignee:J. Moringen% Done:

100%

Category:C++
Target version:rsb-0.10

Related issues

Blocks Robotics Systems Types - Bug #1661: Missing-converter error although the required converter i... Resolved 11/22/2013

Associated revisions

Revision 7e8ecda8
Added by J. Moringen almost 8 years ago

Fix converter selection (again) in src/rsb/Factory.cpp

fixes #1662

The change in 6c1e55c6 broke converter selection by ignoring the
direction (serialization vs. deserialization). In my defense, not a
single unit test failed with the change.

  • src/rsb/Factory.{h,cpp} (ConverterDirection): new enum; used
    file-locally when referring to serialization vs. deserialization
    directions
    (converterSelectionToMap): renamed pairsToMap ->
    converterSelectionToMap; use ConverterDirection
    (prepareConnectorOptions): respect direction; use ConverterDirection
    (Factory::createInPullConnectors): pass direction to
    prepareConnectorOptions
    (Factory::createInPushConnectors): likewise
    (Factory::createOutConnectors): likewise
  • test/rsb/integrationtest.cpp (InformerTest::testConversion): new test;
    make sure converter selection works, at least at a basic level

History

#1 Updated by J. Moringen almost 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset rsb-cpp|commit:7e8ecda8fc48f43c4aeff85f6e4de41bbb2b89a1.

Also available in: Atom PDF