Bug #2028

Maven analysis fails to expand property ref

Added by S. Meyer zu Borgsen almost 10 years ago. Updated almost 10 years ago.

Status:ResolvedStart date:09/26/2014
Priority:NormalDue date:
Assignee:J. Moringen% Done:

100%

Category:Project Analysis
Target version:0.3

Description

This happens if i specify version v5.0:

  ANALYSIS-ERROR:
    Error during analysis of #<PROJECT-SPEC marytts {100B7F39C3}> Caused by:
    > Error during analysis of /tmp/project.vYTTpr/marytts/marytts-signalproc/ Caused by:
    > > Failed to expand property reference "${parent.version}"

For master branch i get:

  ANALYSIS-ERROR:
    Error during analysis of #<PROJECT-SPEC marytts {100B803B73}> Caused by:
    > Error during analysis of /tmp/project.e0Rw67/marytts/marytts-common/ Caused by:
    > > The value ("commons-io/commons-io" NIL) is not of type (CONS STRING (CONS STRING NULL)).

Seems to be introduced in one of the latest commits.

Associated revisions

Revision db72bb01
Added by J. Moringen almost 10 years ago

Allow dependencies without version in src/analysis/maven.lisp

refs #2028

  • src/analysis/maven.lisp (analyze pathname eql :maven): handle
    dependencies without version correctly
    (id->name+version): changed declared return type to permit version nil

Revision 5052939a
Added by J. Moringen almost 10 years ago

Improved property lookup in src/analysis/maven.lisp

refs #2028

  • src/analysis/maven.lisp (analyze pathname eql :maven): support
    "synthetic" properties {parent,project.parent,project}.{groupId,artifactId,version}
    (%resolve-maven-value): accept a property lookup function instead of a
    list of properties
    (%resolve-maven-version): likewise

History

#1 Updated by J. Moringen almost 10 years ago

  • Status changed from New to In Progress
  • Target version set to 0.3
  • % Done changed from 0 to 20

This happens if i specify version v5.0:

I didn't know what that means, but I certainly do not provide the property ${parent.version} for expansion. Should be easy to add, though.

For master branch i get [...]

This is an unversioned dependency, right? If so, I have a fix in my working copy and will probably commit today.

#2 Updated by S. Meyer zu Borgsen almost 10 years ago

For clarification the .project:

{
    "name":      "marytts",
    "templates": [ "cor-lab", "maven"],

    "variables": {
        "keywords":        [ "java" ],

        "repository":      "https://github.com/timobaumann/marytts",
    "scm":     "git", 
           "branches":        ["master", "v5.1", "v5.0"]
    }
}

With versions/branches i mean changing the version in the distribution between master/v5.0.

The POM of the Master contains:

            <dependency>
                <groupId>commons-io</groupId>
                <artifactId>commons-io</artifactId>
                <version>2.0.1</version>
            </dependency>

So a version is specified.

But i have actually no clue where the "${parent.version}" error in the v5.0 branch comes from.

#3 Updated by J. Moringen almost 10 years ago

The POM of the Master contains:

<dependency>
  <groupId>commons-io</groupId>
  <artifactId>commons-io</artifactId>
  <version>2.0.1</version>
</dependency>

There are multiple instances of this dependency:

find . -name 'pom.xml' -type f -exec grep --color -nH -e 'commons-io' {} +
./marytts-common/pom.xml:16:            <groupId>commons-io</groupId>
./marytts-common/pom.xml:17:            <artifactId>commons-io</artifactId>
./pom.xml:167:                <groupId>commons-io</groupId>
./pom.xml:168:                <artifactId>commons-io</artifactId>

and the one in marytts-common does not specify a version.

But i have actually no clue where the "${parent.version}" error in the v5.0 branch comes from.

${parent.version} is used in some sub-modules. It is apparently a deprecated alias for ${project.parent.version}.

#4 Updated by J. Moringen almost 10 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 20 to 100

Seems to be fixed, right?

Also available in: Atom PDF