Feature #2370
rsbag record should perform an introspection survey at the start of each recording
Status: | Resolved | Start date: | 08/28/2015 | |
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | J. Moringen | % Done: | 100% | |
Category: | Commandline Tools | |||
Target version: | Robotics Service Bus - rsb-0.13 |
Description
- Determine transports for introspection survey:
- Map requested recording URIs to transports
- Deduplicate list of transports
- Send survey over these transports, ignoring global transport configuration (using
introspection-receiver
?)
- Commandline option for disabling this behavior
- Maybe later: restrict recorded introspection information to recorded scopes, not just transports
Related issues
Associated revisions
Added recording-bag-connection in src/rsb/bag-connection.lisp
refs #2370
- src/rsb/bag-connection.lisp (header): updated copyright
(recording-bag-connection): new class; specialized bag connection for
recording direction - src/rsb/construction.lisp (events->bag sequence bag): construct a
`recording-bag-connection' instance - src/rsb/package.lisp (header): updated copyright
(package rsbag.rsb): added exported symbol recording-bag-connection
Improve start protocol implementation for connections in src/rsb/*.lisp
refs #2370
Connections no longer accept a start keyword parameter in the
`initialize-instance' methods. Instead, the connection is constructed
and then started via the `start' generic function.
- src/rsb/channel-connection.lisp
(initialize-instance :after recording-channel-connection): removed;
didn't make sense - src/rsb/construction.lisp (events->bag listener bag): do not accept
start? keyword parameter
(events->bag sequence bag): do not pass start? keyword argument to
recursive calls for channel connection; instead call `start' on the
connection once it is constructed
Perform introspection survey on recording start in src/rsb/bag-connection.lisp
fixes #2370
This initial introspection survey allows introspecting the recorded
system based on the recorded data.
- src/rsb/channel-connection.lisp (header): updated copyright
(handle recording-channel-connection event): added hack to ensure
presence of wire-schema and suitable data in event - src/rsb/bag-connection.lisp (start :after recording-bag-connection):
new method; perform introspection survey on all buses for which URLs
have been supplied for recording - test/rsb/package.lisp (header): updated copyright
(test-configuration): new variable; rsb configuration for tests
(test suite rsb-root): added dynamic binding for rsb configuration - cl-rsbag.asd (system cl-rsbag): added system dependency on
rsb-introspection
Mention bag record introspection survey in news.rst
refs #2370
- news.rst (RSBag 0.13): mention introspection survey performed by the
record command at the beginning of recordings
Recording introspection survey is optional in src/rsb/bag-connection.lisp
refs #2370
- src/rsb/bag-connection.lisp
(recording-bag-connection::introspection-survey?): new slot; controls
whether an introspection survey should be performed
(start :after recording-bag-connection): only perform introspection
survey if the introspection-survey? slot says so - src/rsb/construction.lisp (events->bag sequence bag): accept
introspection-survey? keyword parameter pass to
`recording-bag-connection' - test/rsb/protocol.lisp (test events->bag-root::smoke): test
:introspection-survey? keyword argument
Bag record introspection survey in {src/commands/record,bag-record/main}.lisp
refs #2370
- src/commands/record.lisp (record::introspection-survey?): new slot
(command-execute record): - bag-record/main.lisp (update-synopsis):
(main): - CMakeLists.txt: added tests for introspection-survey option of the
record command
introspection-survey commandline option in tool-record.rst
refs #2370
- tool-record.rst (Description): added description of
introspection-survey commandline option - news.rst (RSBag 0.13): mention introspection survey performed by the
record command at the beginning of recordings
History
#1 Updated by J. Moringen over 7 years ago
- Project changed from Robotics Service Bus to RSBag
- Category deleted (
Common Lisp Tools)
#2 Updated by J. Moringen over 7 years ago
- Related to Feature #2373: Implement a rsbag introspect command for introspecting systems described by log files added
#3 Updated by J. Moringen over 7 years ago
- Category set to Commandline Tools
#4 Updated by J. Moringen over 7 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 10
#5 Updated by J. Moringen over 7 years ago
- % Done changed from 10 to 50
#6 Updated by J. Moringen over 7 years ago
- Status changed from In Progress to Resolved
- % Done changed from 50 to 100
Applied in changeset rsbag-cl|d4737ec1ec9cd7320e75d71e2361070ebdf10ec6.