Bug #2520

dependencies reported to jenkins for CI

Added by R. Haschke about 7 years ago. Updated over 6 years ago.

Status:ResolvedStart date:03/14/2016
Priority:UrgentDue date:
Assignee:J. Moringen% Done:

100%

Category:-
Target version:0.6

Description

Die Liste der nachgelagerten Projekte im jenkins ist bei vielen Projekte zu lang.
Nehmen wir mal drei Projekte mit folgenden, beispielhaften Abhängigkeiten:
A
B depends on A
C depends on A,B

In diesem Fall sollte Projekte C nur Projekt B "watchen", weil die dependency auf A automatisch durch ein rebuild von dependency B erfüllt wird.

Da der build-generator potentiel erstmal sehr viele Abhängigkeiten findet, wäre ein solches pruning der Abhängigkeiten in jenkins m.E. auf jeden Fall notwendig.
Zur Zeit triggert ein rebuild von A:
rebuild B, C
rebuild C (after B)

Bei einen großen Projektbaum skaliert das exponentiell schlechter. Bei einer Abhängigkeitsliste A->B->C->D->E->F würde
ein rebuild von A insgesamt 5+4+3+2+1 = 15 weitere builds triggern - obwohl nur 5 nötig wären.

Die Lösung müsste einfach zu implementieren sein:
Man nehme 1. die Abhängigkeitsliste des aktuellen Jobs (wie Du sie schon hast)
und subtrahiere 2. die Abhängigkeitslisten der dort gelisteten Jobs.

Also für unser Beispiel:
A: {} - {} = {}
B: {A} - {} = {A}
C: {A, B} - {} - {A} = {B}

Associated revisions

Revision 9e6d2260
Added by J. Moringen about 7 years ago

Added dependencies.mode behavior in src/project/classes-model.lisp

fixes #2520

Consider the following dependency structure

A<---B<---C
  ^         |
   `--------'

The following values are allowed:

direct (the default)
All jobs corresponding to direct dependencies trigger a given job.
In the above example, A and B trigger C.
minimal
Jobs corresponding to direct dependencies which are not among the
    dependency closure of the direct dependencies trigger a given jobs.
In the above example, only B triggers C (since A is in the
    dependency closure of the direct dependency B).
none
There is no triggering by upstream jobs.
  • src/project/protocol.lisp (header): updated copyright
    (minimal-dependencies): new generic function; compute minimal
    dependencies as described above
    (minimal-dependencies t): new method; default behavior
  • src/project/classes-model.lisp (header): updated copyright
    (deploy-dependencies job): depending on the value of the
    dependencies.mode variable, use direct, minimal or no dependencies
  • src/project/package.lisp (header): updated copyright
    (package jenkins.project): added exported symbol minimal-dependencies

History

#1 Updated by J. Moringen about 7 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 20

#2 Updated by J. Moringen about 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 20 to 100

#3 Updated by R. Haschke almost 7 years ago

Hand which option in distribution or template needs to be set for this feature?

#4 Updated by J. Moringen almost 7 years ago

R. Haschke wrote:

Hand which option in distribution or template needs to be set for this feature?

The variable name is dependencies.mode. I recommend setting it via the -D commandline option. Possible values are:

  • direct (the default)

    All jobs corresponding to direct dependencies trigger a given job.

    In the above example, A and B trigger C.

  • minimal

    Jobs corresponding to direct dependencies which are not among the dependency closure of the direct dependencies trigger a given jobs.

    In the above example, only B triggers C (since A is in the dependency closure of the direct dependency B).

  • none

    There is no triggering by upstream jobs.

#5 Updated by J. Moringen over 6 years ago

  • Target version set to 0.6

Also available in: Atom PDF