Tasks #1016

Move ProtocolBufferConverter Implementation into Header File

Added by S. Wrede almost 12 years ago. Updated over 11 years ago.

Status:ResolvedStart date:06/21/2012
Priority:NormalDue date:
Assignee:J. Wienke% Done:

100%

Category:C++
Target version:rsb-0.9

Description

Rationale: allow an RSB Distribution which does not depend on Protobuf itself but provides the ProtocolBufferConverter to client applications.

Associated revisions

Revision 1d74d796
Added by J. Wienke over 11 years ago

Move implementation of ProtocolBuffer to header only.

This will allows to drop protobuf from the dependencies later on.
The type name functions to convert between data types and wire schemas have been moved to private functions of the converter to avoid non-inline header only implementations.

refs #1016

Revision e9889f4e
Added by J. Wienke over 11 years ago

Move ProtocolBufferConverter implementation to header-only.

Merge branch 'task-1016'

fixes #1016

History

#1 Updated by J. Wienke over 11 years ago

  • Status changed from New to In Progress
  • Assignee set to J. Wienke

#2 Updated by J. Wienke over 11 years ago

There is a first possible solution in the respective feature branch. I moved the type to wire schema functions into private members of the converter to provide a consistent header-only implementation. Do you know whether anyone has used them externally?

#3 Updated by S. Wrede over 11 years ago

Not 100% sure, but at least the existing converters don't use it.

#4 Updated by J. Wienke over 11 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset rsb-cpp|commit:e9889f4ea073753eb8c156f35a6247ebfbd84eba.

Also available in: Atom PDF