Bug #1434

Orientation::rotateby method is wrong

Added by C. Emmerich about 11 years ago. Updated about 11 years ago.

Status:ResolvedStart date:02/20/2013
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:-
Target version:-

Description

The rotateby-method of the class Orientation is erroneous, because the order of the rotation members is permuted. The current implementation

OrientationPtr Orientation::rotateBy(const OrientationPtr& rot) const {
    return Orientation::fromQuaternion(this->_quaternion * rot->asQuaternion());
}

should be changed to
OrientationPtr Orientation::rotateBy(const OrientationPtr& rot) const {
    return Orientation::fromQuaternion(rot->asQuaternion() * this->_quaternion);
}

Associated revisions

Revision 665
Added by C. Emmerich about 11 years ago

corrected implementation of rotate method in trunk(refs #1434)

Revision 667
Added by C. Emmerich about 11 years ago

fixed rotateby-method also in 0.3 (fixes #1434)

History

#1 Updated by C. Emmerich about 11 years ago

  • Status changed from New to Feedback
  • Assignee changed from C. Emmerich to Anonymous
  • % Done changed from 0 to 50

applied in trunk.

@Arne: should I also apply it in 0.3?

#2 Updated by Anonymous about 11 years ago

Yes, please also backport to 0.3.

#3 Updated by C. Emmerich about 11 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 50 to 100

Applied in changeset r667.

Also available in: Atom PDF