Feature #2378
Add CardInformation and CardController to the sandbox
| Status: | Rejected | Start date: | 09/01/2015 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | Type Proposal | |||
| Target version: | - |
History
#1 Updated by J. Wienke almost 9 years ago
Sorry, but the patch in the current form cannot be included. I see several major issues with this:
- Documentation is missing to a large extent
- The coding style does not follow the usual conventions
- Naming is hardly understandable for users not familiar with the specific scenario. What is a "CardController". This severely impacts possible reuse of these types.
Additionally, I have the feelings that the chosen abstractions are not optimal. Both types look very specific for the use case and existing abstractions aren't used. E.g. for CardInformation.Card one could probably reuse rst.classification.ClassifiedRegion2D
Could you please explain what you are currently trying to represent with these types. Maybe we can then find a way to structure the data in a more consistent way and along the current design ideas of RST.
#2 Updated by J. Wienke almost 9 years ago
How to proceed here?
#3 Updated by A. Kipp almost 9 years ago
Can be closed.
Solved with other types.
#4 Updated by J. Wienke almost 9 years ago
- Status changed from New to Rejected