Feature #2443
resource allocation type for the apartment (for version 0.13)
Status: | Closed | Start date: | 11/23/2015 | ||
---|---|---|---|---|---|
Priority: | Normal | Due date: | |||
Assignee: | - | % Done: | 30% | ||
Category: | Type Proposal | ||||
Target version: | Robotics Service Bus - rsb-0.15 |
History
#1 Updated by J. Moringen over 8 years ago
- Status changed from New to In Progress
- Assignee set to J. Moringen
Reviewing …
#2 Updated by J. Moringen over 8 years ago
- File 0001-changes.patch added
- % Done changed from 0 to 30
Attached is an updated version with the following changes
- Renamed
ResourceAllocation
->ResourceAllocationRequest
(but see first remaining issue) - fixed copy/paste documentation strings
- Typo fixes
- The descriptions of the
resource_ids
andlocation_ids
seem insufficient (see http://docs.cor-lab.de/rst-manual/trunk/html/conventions.html#best-practices-for-documentation-strings forrepeated
fields). Reading "required/allocated" makes me uncertain whether I misunderstood the whole type. It is probably not an allocation request but rather an exchange about resource allocation, right? If so, the documentation string of the message itself should make this clear. - If the type actually represents an exchange, how is the outcome communicated? Is the message intended to be contained in a
TaskState
message? If so, the fact should be documented. - What is meant by "location" in the context of this type?
- Depends on homeautomation types. Can this be avoided to make the type more generally applicable? Also, homeautomation types will probably not be available in this repository for some time.
- The name "NO" of the lowest priority is not very clear.
#3 Updated by J. Moringen over 8 years ago
- File 0001-changes.patch added
Attached one additional change: the protocol buffer code generation assumes that field names are singular, even for repeated fields.
#4 Updated by J. Moringen about 8 years ago
- Target version changed from rsb-0.13 to rsb-0.14
#5 Updated by J. Moringen about 8 years ago
- Status changed from In Progress to Feedback
Should this type still be added at some point?
#6 Updated by J. Moringen almost 8 years ago
- Target version changed from rsb-0.14 to rsb-0.15
#7 Updated by J. Moringen almost 8 years ago
Any updates?
#8 Updated by J. Moringen almost 8 years ago
- Assignee deleted (
J. Moringen)
#9 Updated by P. Holthaus almost 8 years ago
- Status changed from Feedback to Closed
Opening a new issue with a revised type.