Bug #983
Revise Rotation.proto
| Status: | Resolved | Start date: | 04/18/2012 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | J. Wienke | % Done: | 100% | |
| Category: | protocol | |||
| Target version: | - |
Description
source:trunk/rst/proto/stable/rst/geometry/Rotation.proto defines all its fields to be optional, and starts with field index 4. Probably copy&past error from a former pose representation.
- Changing
optionaltorequiredshould be no problem at all even in stable (there is most probably only user code out there using all four quaternion components anyway) - Changing field index is not binary compatible
Associated revisions
Make the elements of the quaternion required. Otherwise the quaternion is invalid which should not be the default case.
fixes #983
History
#1 Updated by J. Wienke about 12 years ago
I don't see a reason to change the field indices. But making the fields required is in this case a reasonable idea. Usually, you should be very careful about requiring fileds for preserving compatibility.
#2 Updated by J. Wienke about 12 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset r307.