Feature #1530
Add new types representing classifications results and sensor properties to the sandbox
Status: | Resolved | Start date: | 05/31/2013 | |
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | J. Moringen | % Done: | 100% | |
Category: | Type Proposal | |||
Target version: | Robotics Service Bus - rsb-0.9 |
Associated revisions
Added ClassifiedRegion2D which represents classification results from a 2d visual recognition process
refs #1530
Added ClassifiedRegion3D which represents classification results from a 3d visual recognition process
refs #1530
Added CameraPose which represents the 3d pose of a camera with annotation of the coordinate system
refs #1530
Added FieldOfView representing the angular extent of a sensor's field of view
refs #1530
Added ViewFrustum representing a sensor's view frustum
refs #1530
Added LocatedXYZImage which adds location, perceived space to a point cloud
refs #1530
History
#1 Updated by J. Moringen almost 11 years ago
Should the proposed types be added to the master branch?
#2 Updated by L. Ziegler almost 11 years ago
yes
#3 Updated by J. Moringen almost 11 years ago
- Status changed from New to In Progress
- Assignee set to J. Moringen
- Target version set to rsb-0.9
#4 Updated by J. Wienke almost 11 years ago
I see indentation inconsistencies in the patch.
#5 Updated by J. Moringen almost 11 years ago
I already made an updated version. I will attach that patch together with some feedback in a few minutes.
#6 Updated by J. Moringen almost 11 years ago
- File 0001-temp-commit-message.patch added
The attached updated version of the patch fixes most obvious problems.
However, I request the following additional changes:
- Check whether the @constraints I added are correct
- Split the patch into individual commits (these can still be submitted in a single patch file)
- Describe the added data types in the respective commit messages
- Fix TODOs:
CameraPose.proto
: extend description; document pose fieldFieldOfView.proto
: extend description
- In
Frustum.proto
,angular_resolution_{x,z}
have identical documentation strings (and miss a fullstop at the end). Frustum
seems unnecessarily complicated to me: depending oncamera.coordinate_frame
, the whole geometric interpretation seems to changeLocatedXYZImage
inherits this problem fromFrustum
#7 Updated by L. Ziegler almost 11 years ago
Here is an updated patch file including several commit. I hope I fixed all remaining issues.
#8 Updated by J. Moringen almost 11 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
I committed the proposed types with minor comment- and whitespace-fixes.