Feature #1530

Add new types representing classifications results and sensor properties to the sandbox

Added by L. Ziegler almost 11 years ago. Updated almost 11 years ago.

Status:ResolvedStart date:05/31/2013
Priority:NormalDue date:
Assignee:J. Moringen% Done:

100%

Category:Type Proposal
Target version:Robotics Service Bus - rsb-0.9

0001-Added-more-types-represent-classification-results-an.patch Magnifier (7.07 KB) L. Ziegler, 05/31/2013 05:39 PM

0001-temp-commit-message.patch Magnifier (7.31 KB) J. Moringen, 05/31/2013 07:03 PM

classification_results_and_sensor_properties.patch Magnifier (9.96 KB) L. Ziegler, 06/04/2013 11:29 AM

Associated revisions

Revision 09da34c1
Added by L. Ziegler almost 11 years ago

Added ClassifiedRegion2D which represents classification results from a 2d visual recognition process

refs #1530

Revision 02c8d031
Added by L. Ziegler almost 11 years ago

Added ClassifiedRegion3D which represents classification results from a 3d visual recognition process

refs #1530

Revision 0ab81762
Added by L. Ziegler almost 11 years ago

Added CameraPose which represents the 3d pose of a camera with annotation of the coordinate system

refs #1530

Revision 63b06ed4
Added by L. Ziegler almost 11 years ago

Added FieldOfView representing the angular extent of a sensor's field of view

refs #1530

Revision 3950ad87
Added by L. Ziegler almost 11 years ago

Added ViewFrustum representing a sensor's view frustum

refs #1530

Revision b4ca3f5e
Added by L. Ziegler almost 11 years ago

Added LocatedXYZImage which adds location, perceived space to a point cloud

refs #1530

History

#1 Updated by J. Moringen almost 11 years ago

Should the proposed types be added to the master branch?

#2 Updated by L. Ziegler almost 11 years ago

yes

#3 Updated by J. Moringen almost 11 years ago

  • Status changed from New to In Progress
  • Assignee set to J. Moringen
  • Target version set to rsb-0.9

#4 Updated by J. Wienke almost 11 years ago

I see indentation inconsistencies in the patch.

#5 Updated by J. Moringen almost 11 years ago

I already made an updated version. I will attach that patch together with some feedback in a few minutes.

#6 Updated by J. Moringen almost 11 years ago

The attached updated version of the patch fixes most obvious problems.

However, I request the following additional changes:

  • Check whether the @constraints I added are correct
  • Split the patch into individual commits (these can still be submitted in a single patch file)
    • Describe the added data types in the respective commit messages
  • Fix TODOs:
    • CameraPose.proto: extend description; document pose field
    • FieldOfView.proto: extend description
  • In Frustum.proto, angular_resolution_{x,z} have identical documentation strings (and miss a fullstop at the end).
  • Frustum seems unnecessarily complicated to me: depending on camera.coordinate_frame, the whole geometric interpretation seems to change
  • LocatedXYZImage inherits this problem from Frustum

#7 Updated by L. Ziegler almost 11 years ago

Here is an updated patch file including several commit. I hope I fixed all remaining issues.

#8 Updated by J. Moringen almost 11 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

I committed the proposed types with minor comment- and whitespace-fixes.

Also available in: Atom PDF