Enhancement #2309

New RCI Converter JointVelocities

Added by N. Dehio over 6 years ago. Updated over 6 years ago.

Status:ResolvedStart date:06/01/2015
Priority:NormalDue date:06/03/2015
Assignee:J. Wienke% Done:

100%

Category:cpp
Target version:-

Description

I added a new rci converter for JointVelocities.
Please upload the attached patch.

0001-added-rci-converter-for-JointVelocities.patch Magnifier (8.46 KB) N. Dehio, 06/01/2015 04:31 PM

0001-new-rci-converter-for-joint-velocities-with-updated-.patch Magnifier (8.48 KB) N. Dehio, 06/02/2015 09:21 AM

Associated revisions

Revision 6f29598d
Added by N. Dehio over 6 years ago

new rci converter for joint velocities

fixes #2309

Signed-off-by: Johannes Wienke <>

Revision 7376e57f
Added by N. Dehio over 6 years ago

new rci converter for joint velocities

fixes #2309

Signed-off-by: Johannes Wienke <>

Revision d03d6f32
Added by N. Dehio over 5 years ago

new rci converter for joint velocities

fixes #2309

Signed-off-by: Johannes Wienke <>

History

#1 Updated by J. Wienke over 6 years ago

A few comments wrt the patch:
  • Please fix the copyright statement in the headers
  • Remove the various whitespaces before uses of ::rci::JointVelocities
  • The header file lacks a new line at the end of file
    Otherwise this looks fine.

#2 Updated by N. Dehio over 6 years ago

new patch attached:
- updated copyright
- new line at the end of header file
=> removing whitespaces before uses of ::rci::JointVelocities leads to compiling errors. This change is not included.

#3 Updated by J. Wienke over 6 years ago

N. Dehio wrote:

=> removing whitespaces before uses of ::rci::JointVelocities leads to compiling errors. This change is not included.

Hm, the only place where I could imagine this could be inside the RSB_TYPE_TAG macro... All other places are plain C++ without preprocessor being involved. But I can have a look at that as well.

#4 Updated by N. Dehio over 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF