Tasks #2450: extend face type with gaze informations - Robotics Systems Types - Open Source Collaboration Platform

Tasks #2450

extend face type with gaze informations

Added by B. Carlmeyer over 7 years ago. Updated over 7 years ago.

Status:

Resolved

Start date:

12/01/2015

Priority:

Normal

Due date:

Assignee:

J. Wienke

% Done:

100%

Category:

Type Proposal

Target version:

Robotics Service Bus - rsb-0.13

Description

I would like to add some gaze informations in the face type.

0001-extend-face-type.patch (1.51 KB) B. Carlmeyer, 12/01/2015 02:58 PM

0001-add-new-FaceWithGaze-type.patch (1.6 KB) B. Carlmeyer, 12/10/2015 10:48 AM

0001-added-new-FaceWithGaze-type.patch (1.92 KB) B. Carlmeyer, 12/17/2015 03:12 PM

Associated revisions

Revision 43d981a4
Added by J. Wienke over 7 years ago

Add missing comments in Face

refs #2450
refs #2152

Revision 6d263ec5
Added by B. Carlmeyer over 7 years ago

New type FaceWithGaze

fixes #2450

Signed-off-by: Johannes Wienke <jwienke@techfak.uni-bielefeld.de>

History

#1 Updated by J. Wienke over 7 years ago

I am not sure about the two boolean additions. Why are they necessary? Both could be derived from the other values.

#2 Updated by B. Carlmeyer over 7 years ago

J. Wienke wrote:

I am not sure about the two boolean additions. Why are they necessary? Both could be derived from the other values.

yes, both could be derived from the other values, but we have a component that already evaluates these values.

#3 Updated by J. Wienke over 7 years ago

Status changed from New to In Progress
Assignee set to J. Wienke
Target version set to rsb-0.13

#4 Updated by J. Wienke over 7 years ago

B. Carlmeyer wrote:

J. Wienke wrote:

I am not sure about the two boolean additions. Why are they necessary? Both could be derived from the other values.

yes, both could be derived from the other values, but we have a component that already evaluates these values.

This is a problem. Because with this redundancy the potential for misinterpretation gets higher.

Generally, we would like to avoid feature creep in the Face type. Therefore our proposal would be as follows:

Create a generic Euler Angles type for the head orientation (e.g. as yaw, pitch and roll with radiant as unit) and use that type instead of the custom fields
Create a new type (something like FaceWithGaze or GazeInformation) which assembles a usual Face and the gaze-related variables.

Apart from that:

Boolean variables should not have an is_ prefix. The proto compiler will automatically add this for the accessor methods.

Would such a plan be realizable?

#5 Updated by B. Carlmeyer over 7 years ago

File 0001-add-new-FaceWithGaze-type.patch added

J. Wienke wrote:

Would such a plan be realizable?

Please see the attached patch.

#6 Updated by J. Wienke over 7 years ago

For the gaze estimation, the comment does not explain which directions are represented by positive and negative values. Can you clarify this? Apart from that everything is fine.