Tasks #2450

extend face type with gaze informations

Added by B. Carlmeyer almost 7 years ago. Updated almost 7 years ago.

Status:ResolvedStart date:12/01/2015
Priority:NormalDue date:
Assignee:J. Wienke% Done:

100%

Category:Type Proposal
Target version:Robotics Service Bus - rsb-0.13

Description

I would like to add some gaze informations in the face type.

0001-extend-face-type.patch Magnifier (1.51 KB) B. Carlmeyer, 12/01/2015 02:58 PM

0001-add-new-FaceWithGaze-type.patch Magnifier (1.6 KB) B. Carlmeyer, 12/10/2015 10:48 AM

0001-added-new-FaceWithGaze-type.patch Magnifier (1.92 KB) B. Carlmeyer, 12/17/2015 03:12 PM

Associated revisions

Revision 43d981a4
Added by J. Wienke almost 7 years ago

Add missing comments in Face

refs #2450
refs #2152

Revision 6d263ec5
Added by B. Carlmeyer almost 7 years ago

New type FaceWithGaze

fixes #2450

Signed-off-by: Johannes Wienke <>

History

#1 Updated by J. Wienke almost 7 years ago

I am not sure about the two boolean additions. Why are they necessary? Both could be derived from the other values.

#2 Updated by B. Carlmeyer almost 7 years ago

J. Wienke wrote:

I am not sure about the two boolean additions. Why are they necessary? Both could be derived from the other values.

yes, both could be derived from the other values, but we have a component that already evaluates these values.

#3 Updated by J. Wienke almost 7 years ago

  • Status changed from New to In Progress
  • Assignee set to J. Wienke
  • Target version set to rsb-0.13

#4 Updated by J. Wienke almost 7 years ago

B. Carlmeyer wrote:

J. Wienke wrote:

I am not sure about the two boolean additions. Why are they necessary? Both could be derived from the other values.

yes, both could be derived from the other values, but we have a component that already evaluates these values.

This is a problem. Because with this redundancy the potential for misinterpretation gets higher.

Generally, we would like to avoid feature creep in the Face type. Therefore our proposal would be as follows:
  • Create a generic Euler Angles type for the head orientation (e.g. as yaw, pitch and roll with radiant as unit) and use that type instead of the custom fields
  • Create a new type (something like FaceWithGaze or GazeInformation) which assembles a usual Face and the gaze-related variables.
Apart from that:
  • Boolean variables should not have an is_ prefix. The proto compiler will automatically add this for the accessor methods.

Would such a plan be realizable?

#5 Updated by B. Carlmeyer almost 7 years ago

J. Wienke wrote:

Would such a plan be realizable?

Please see the attached patch.

#6 Updated by J. Wienke almost 7 years ago

For the gaze estimation, the comment does not explain which directions are represented by positive and negative values. Can you clarify this? Apart from that everything is fine.

#7 Updated by J. Wienke almost 7 years ago

Ping

#8 Updated by J. Moringen almost 7 years ago

Please coordinate with the GazeTarget type being added for the hlc stack.

#9 Updated by B. Carlmeyer almost 7 years ago

J. Wienke wrote:

Ping

Pong.... Sorry for the delay in replying and see the attached patch.

#10 Updated by B. Carlmeyer almost 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF