Feature #2483

RST types for HLC / Flobi

Added by S. Schulz over 7 years ago. Updated about 7 years ago.

Status:ResolvedStart date:12/17/2015
Priority:HighDue date:
Assignee:J. Wienke% Done:

100%

Category:Type ProposalEstimated time:2.00 hours
Target version:Robotics Service Bus - rsb-0.13

Description

i attached a revised patch to this issue.

note that not all suggestions were merged, i rather had a look how
other message types were implemented in rst stable and used the same
approach.

patch4hlc.diff Magnifier (4.72 KB) S. Schulz, 12/17/2015 10:46 AM

patch4hlc_.diff Magnifier (4.73 KB) S. Schulz, 12/17/2015 10:48 AM

reversed.patch Magnifier (4.29 KB) S. Schulz, 01/05/2016 12:42 PM

0001-New-types-to-describe-animations-for-Flobi.patch Magnifier (7.35 KB) J. Wienke, 01/05/2016 02:49 PM

0001-New-types-to-describe-animations-for-Flobi_FIXED.patch Magnifier (7.3 KB) S. Schulz, 01/05/2016 03:13 PM

rsb012 (765 Bytes) S. Schulz, 01/08/2016 04:50 PM

Associated revisions

Revision 8f7c327a
Added by Simon Schulz about 7 years ago

New types to describe animations for Flobi

fixes #2483

Signed-off-by: Johannes Wienke <>

Revision 3ec1380d
Added by Simon Schulz about 7 years ago

New types to describe animations for Flobi

fixes #2483

Signed-off-by: Johannes Wienke <>
(cherry picked from commit 8f7c327a3b03461f8c98c4a2cc28990fea373d3b)

History

#1 Updated by S. Schulz over 7 years ago

#2 Updated by S. Schulz over 7 years ago

please use patch4hlc_.diff

#3 Updated by J. Wienke over 7 years ago

The patch is broken. It removes files that didn't exist.

#4 Updated by J. Wienke over 7 years ago

  • Category set to protocol
  • Target version set to rsb-0.13

#5 Updated by S. Schulz about 7 years ago

my fault, the patch was not delting files, i created a reversed patch.
please use reversed.patch.

I think this should be merged into rst 0.12 for the grossgerätebegehung in january

#6 Updated by J. Wienke about 7 years ago

Attached is a reworked patch. Please check the TODOs and modifications.

The new type SphericaldirectionFlaot is already in master.

#7 Updated by J. Wienke about 7 years ago

  • Status changed from New to Feedback

#8 Updated by S. Schulz about 7 years ago

i fixed all todos, please merge

#9 Updated by Anonymous about 7 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 50 to 100

#10 Updated by S. Schulz about 7 years ago

ok, seems like collections are not supported in 0.12

i suggest the following change/patch. it does not change much and this way we can work with the rst types in 0.12 as well.

#11 Updated by J. Wienke about 7 years ago

That means you need a backport of everything in 0.12 as well?

#12 Updated by S. Schulz about 7 years ago

yes, unfortunately that was always a requirement :(

#13 Updated by J. Wienke about 7 years ago

  • Status changed from Resolved to In Progress
  • % Done changed from 100 to 80

your proposed changes will, however, change the API between 0.12 and 0.13. I'd propose to add a patch only to 0.12 which recreates the PhonemeCollection manually as it would be generated automatically in 0.13.

#14 Updated by S. Schulz about 7 years ago

no, please change both, 0.13 and 0.12, rst types to use the version using repeated instead of collection.
this works for both, 0.12 and 0.13 without any changes.

#15 Updated by J. Wienke about 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

#16 Updated by J. Wienke about 7 years ago

  • Category changed from protocol to Type Proposal

Also available in: Atom PDF