Feature #2154

Add new dialog types to sandbox

Added by B. Carlmeyer over 9 years ago. Updated over 8 years ago.

Status:ResolvedStart date:01/12/2015
Priority:NormalDue date:
Assignee:J. Wienke% Done:

100%

Category:Type Proposal
Target version:Robotics Service Bus - rsb-0.13

Description

Please add the new types for the communication with the dialog manager pamini to the sandbox.

0001-add-new-data-types-for-the-communication-with-the-di.patch Magnifier (3.4 KB) B. Carlmeyer, 01/12/2015 09:39 AM

0001-Added-dialog-data-types-in-proto-sandbox-rst-dialog.patch Magnifier (3.83 KB) J. Moringen, 01/12/2015 11:07 AM

0001-Added-dialog-data-types-in-proto-sandbox-rst-dialog.patch Magnifier (6.69 KB) B. Carlmeyer, 09/07/2015 01:19 PM


Related issues

Related to Robotics Systems Types - Bug #2451: update incremental unit type Resolved 12/02/2015

Associated revisions

Revision c47313c8
Added by B. Carlmeyer over 8 years ago

Added dialog data types in proto/sandbox/rst/dialog

New types
  • DialogAct
  • DialogManagerCommand
  • IncrementalUnit

fixes #2154

Signed-off-by: Johannes Wienke <>

Revision c604e63f
Added by J. Wienke over 8 years ago

Add a state machine description to StateChange

Allows to express which state machine changed its state.

refs #2154

Revision 711a1058
Added by B. Carlmeyer over 8 years ago

Added dialog data types in proto/sandbox/rst/dialog

New types
  • DialogAct
  • DialogManagerCommand
  • IncrementalUnit

fixes #2154

Signed-off-by: Johannes Wienke <>
(cherry picked from commit c47313c80b4db44383ff91bb2286fd1773bdffd9)

History

#1 Updated by J. Moringen over 9 years ago

  • Status changed from New to In Progress
  • Assignee set to J. Moringen
  • Target version set to rsb-0.12

#2 Updated by J. Moringen over 9 years ago

I reviewed the proposed type and made an updated patch (attached) with some suggested changes. Most changes are minor and syntactic (see notes below).

However, the following semantic aspects require feedback from you:
  • A number of documentation strings or are missing are too short for non-domain-experts to understand. Please extend those (marked as TODO in the updated patch)
  • The name DialogAct may not be appropriate since the edittype field seems to make the message a database operation the subject of which is a dialog act.
  • The patch introduces a new dialog package. Would the types in #2143 also fit into this package?
Notes regarding minor corrections:
  • DialogAct
    • Unnecessary restriction to a specific software: "A description of a dialog act for the dialog manager pamini."
    • DialogAct.EditType
      • Typo: "The dialog act can be in diffe ren t states."
      • Comment individual enum values
      • COMMIT –: that's an "EN DASH", while the others are - ("HYPHEN-MINUS")
  • DialogManagerCommand
    • Typo in file and message name DialogMan a gerCommand
    • Unnecessary restriction to a specific software: "A description of a command for the dialog manager pamini."
    • Command
      • Use /** */-style comments
  • InteractionPatternInfo
    • Unnecessary restriction to a specific software: "A description of a current state of a pamini interaction pattern."
    • Use /** */-style comments

#3 Updated by J. Wienke almost 9 years ago

  • Target version changed from rsb-0.12 to rsb-0.13

#4 Updated by J. Wienke over 8 years ago

Birte?

#5 Updated by B. Carlmeyer over 8 years ago

Oh, das Issue ist bei mir ja total untergegangen, danke fürs aktualisieren! Ich hatte vor meinem langen Krankheitsausfall da noch einiges dran geaendert. Steht für Montag auf meiner Todo-Liste

#6 Updated by B. Carlmeyer over 8 years ago

I made an updated patch (attached). Sorry for the delay!

A number of documentation strings or are missing are too short for non-domain-experts to understand. Please extend those (marked as TODO in the updated patch)

Documentation is extended.

The name DialogAct may not be appropriate since the edittype field seems to make the message a database operation the subject of which is a dialog act.

The edittype field is part of the "Incremental Unit Model of Incremental Dialogue Processing". For a better understanding of the model I created a separate "Incremental Unit" type (with further optional data fields).

The patch introduces a new dialog package. Would the types in #2143 also fit into this package?

Yes, I think so.

#7 Updated by J. Wienke over 8 years ago

  • Status changed from Feedback to In Progress
  • Assignee changed from B. Carlmeyer to J. Wienke

#8 Updated by B. Carlmeyer over 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100

#9 Updated by J. Moringen over 8 years ago

  • Related to Bug #2451: update incremental unit type added

Also available in: Atom PDF