Enhancement #2707
Patch for expanding person hypothesis
| Status: | Resolved | Start date: | 01/26/2017 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | J. Moringen | % Done: | 100% | |
| Category: | Type Proposal | |||
| Target version: | Robotics Service Bus - rsb-0.16 |
Description
Please review and add the following patch!
These types are used in the CSRA project.
Associated revisions
Added head field to rst.hri.PersonHypothesis
fixes #2707
Signed-off-by: Jan Moringen <jmoringe@techfak.uni-bielefeld.de>
Backport: New type rst.hri.Head
Copied (with modifications) from rst-experimental project.
refs #2707
(cherry picked from commit 86496c14b8400a8cbf0ba8f94eec5e059566a0e3)
Backport: Added head field to rst.hri.PersonHypothesis
refs #2707
Signed-off-by: Jan Moringen <jmoringe@techfak.uni-bielefeld.de>
(cherry picked from commit 196ba811ff742592aa1c38563a6756f3ef4629ea)
History
#1 Updated by J. Moringen over 6 years ago
- File 0001-New-type-rst.hri.Head.patch
added - File 0002-Added-head-field-to-rst.hri.PersonHypothesis.patch added
- Category set to Type Proposal
- Status changed from New to Feedback
- Target version set to rsb-0.16
We added the missing rst.hri.Head type and tweaked the patch accordingly. Please have a look at the attached patches and let us known whether the updated version work for you.
#2 Updated by N. Köster over 6 years ago
It would be good if this change can also be back-ported to 0.15. Thanks!
#3 Updated by K. Konen over 6 years ago
Looks good.
Thank you.
The rst.hri.Head type is already implemented in the rst-experimental. Is this a problem/Does it have to be deleted there?
#4 Updated by R. Zorn over 6 years ago
Suggested patch works and can be applied.
#5 Updated by J. Moringen over 6 years ago
K. Konen wrote:
The rst.hri.Head type is already implemented in the rst-experimental. Is this a problem/Does it have to be deleted there?
Types in RST cannot depend on rst-experimental, so we added the rst.hri.Head to RST. To use RST in conjunction with rst-experimental, the type in rst-experimental has to be renamed or removed.
#6 Updated by R. Zorn over 6 years ago
- Status changed from Feedback to Resolved
- % Done changed from 0 to 100
Applied in changeset rst-proto|196ba811ff742592aa1c38563a6756f3ef4629ea.