Enhancement #2478
Add Highlight Target type
| Status: | Resolved | Start date: | 12/11/2015 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | J. Wienke | % Done: | 100% | |
| Category: | Type Proposal | |||
| Target version: | Robotics Service Bus - rsb-0.13 |
Description
see attached patch file.
0001-add-highlight-target-type.patch 
(1.88 KB)
0002-rename-type.patch
(3.47 KB)
0001-add-highlight-target-type.patch
(1.85 KB)
Associated revisions
Add highlight target type
fixes #2478
Signed-off-by: Johannes Wienke <jwienke@techfak.uni-bielefeld.de>
Add highlight target type
fixes #2478
Signed-off-by: Johannes Wienke <jwienke@techfak.uni-bielefeld.de>
(cherry picked from commit bee6f472660d3f93583b1efa3bd5293fc00e573c)
History
#1 Updated by P. Holthaus over 8 years ago
- File 0002-rename-type.patch added
oops, wrong file ending. also aligned comments
#2 Updated by J. Wienke over 8 years ago
- Status changed from New to In Progress
Can you please boil down the changes into a single patch that can be applied?
#3 Updated by J. Wienke over 8 years ago
- Assignee set to J. Wienke
#4 Updated by P. Holthaus over 8 years ago
- File 0001-add-highlight-target-type.patch added
here you go.
#5 Updated by J. Wienke over 8 years ago
- File 0001-Add-highlight-target-type.patch added
I have slightly revised the patch. for formal issues and changed a few names of the enumeration to be better recognizable. Is it ok to rename "GAZE" to "AGENT", since it sound strange to me that an "intelligent apartment" (as in the type description) can actually gaze.
#6 Updated by P. Holthaus over 8 years ago
I cannot find any differences between the patch I provided and the file you uploaded.
J. Wienke wrote:
Is it ok to rename "GAZE" to "AGENT", since it sound strange to me that an "intelligent apartment" (as in the type description) can actually gaze.
The type itself should imho not be apartment-specific, but as the description says for all kinds of "intelligent systems". We have explicitly designed it to use it as a common type shared with the Meka bot as well. Therefore, I would refrain from renaming the field.
#7 Updated by J. Wienke over 8 years ago
- File deleted (
0001-Add-highlight-target-type.patch)
#8 Updated by J. Wienke over 8 years ago
- File 0001-Add-highlight-target-type.patch added
Oops, attached is the patch containing the changes.
Is it ok to rename "GAZE" to "AGENT", since it sound strange to me that an "intelligent apartment" (as in the type description) can actually gaze.
The type itself should imho not be apartment-specific, but as the description says for all kinds of "intelligent systems". We have explicitly designed it to use it as a common type shared with the Meka bot as well. Therefore, I would refrain from renaming the field.
I don't understand this argument. Isn't the mekabot some kind of agent?
#9 Updated by P. Holthaus over 8 years ago
Yes, but an agent can use gaze and/or gesture, LEDs, beeps for example.
#10 Updated by Anonymous over 8 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset rst-proto|bee6f472660d3f93583b1efa3bd5293fc00e573c.